From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D08A942D6E; Tue, 27 Jun 2023 09:28:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 678294113F; Tue, 27 Jun 2023 09:28:43 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C607440F18 for ; Tue, 27 Jun 2023 09:28:41 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BECC95C021E; Tue, 27 Jun 2023 03:28:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 27 Jun 2023 03:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687850918; x=1687937318; bh=eJSwczn/VEqLxjH/Grybz+dBErBssW+Hwoy gMvOdRhQ=; b=lu8Cz8sVnREE16OKycaBukeJIE5vkYApfXSc7VyuC9tEQ5iXlvh Awkdmg8DOgnklr2PQAzK3jBJjhkvACIDsl6xuOJkAjkUyBbHFxGYNfBO4qiDpWJl qYyHfgiWxeHM3m885/D8rAWIhsdzEr3wfXZSf2yGsKeaGRUzL++wWC5C3rH0jQRj Jfzq+PQXDG/Aq56id/8UE0w9VfKGaU7z0GNyYKXoqIIw9bNV+suPO3qtqBKyPOKz XNE2MVWGZHsDKOb8kfnvSgkbePAVwnyagxLmy7ScRqwiGc628fgmuIFVP5C6o7te fE8Hh4GaphhBBtzi5gsLtoPToTpWv28hpmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687850918; x=1687937318; bh=eJSwczn/VEqLxjH/Grybz+dBErBssW+Hwoy gMvOdRhQ=; b=XGfCw6JvKG0a9fj133eWZpMlJShRK1cl/cjs105sHfJcbX/LVmi z3h5xlQynsBaXRWn1LwbCaZjUAdb2SS2MmNoQaGjHmm5QWCFJ3MBZQ7mIhataTjR AvLn0Bb4ZznYlOH/O3Xos6i+BO/vsfYbXHwqnbsIsHuQWVIeDWwYXnoezhV/V9Ba Msid4yfxX6OD7eblbTaHu81SY6eshUUpxC1I7W6JoJtKdEvDvIxoHsHpBC8JtqvE z8FOI+4oF0We3Z6vyu+rmTxUHUPaSR2AV27YpiHejSatLOUfLdn9/vshu/NI3k/W 5trBNhFif3vOeYf3kmBE1MEgR9HeVZ3tr0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehgedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 03:28:37 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko Cc: "dev@dpdk.org" , Jerin Jacob , Raslan Darawsheh Subject: Re: [RFC 2/5] common/mlx5: introduce tracepoints for mlx5 drivers Date: Tue, 27 Jun 2023 09:28:36 +0200 Message-ID: <2800790.AiC22s8V5E@thomas> In-Reply-To: References: <20230420100803.494-1-viacheslavo@nvidia.com> <2594368.9Mp67QZiUf@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/06/2023 08:15, Slava Ovsiienko: > From: Thomas Monjalon > > 13/06/2023 18:01, Jerin Jacob: > > > On Tue, Jun 13, 2023 at 9:29=E2=80=AFPM Slava Ovsiienko > > wrote: > > > > From: Jerin Jacob > > > > > On Tue, Jun 13, 2023 at 9:20=E2=80=AFPM Slava Ovsiienko > > > > > > > > > > wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > <..snip..> > > > > > > > > > > > > > > > > mlx5_os_interrupt_handler_create; # WINDOWS_NO_EXPO= RT > > > > > > > > mlx5_os_interrupt_handler_destroy; # > > > > > > > > WINDOWS_NO_EXPORT > > > > > > > > + > > > > > > > > + __rte_pmd_mlx5_trace_tx_entry; > > > > > > > > + __rte_pmd_mlx5_trace_tx_exit; > > > > > > > > + __rte_pmd_mlx5_trace_tx_wqe; > > > > > > > > + __rte_pmd_mlx5_trace_tx_wait; > > > > > > > > + __rte_pmd_mlx5_trace_tx_push; > > > > > > > > + __rte_pmd_mlx5_trace_tx_complete; > > > > > > > > > > > > > > No need to expose these symbols. It is getting removed from r= est of > > DPDK. > > > > > > > Application can do rte_trace_lookup() to get this address. > > > > > > > > > > > > > > > > > > > > It is not for application, it is for PMD itself, w/o exposing > > > > > > the symbols build > > > > > failed. > > > > > > > > > > PMD is implementing this trace endpoints, not consuming this trace > > point. > > > > > Right? If so, Why to expose these symbols? > > > > > > > > As far as understand: > > > > The tracepoint routines are defined in dedicated common/mlx5_trace.c > > file. > > > > The tx_burst in mlx5 is implemented as template in header file, and > > > > this template is used in multiple .c files under net/mlx5 filder. > > > > So, common/mlx5 should expose its symbols to net/mlx5 to allow > > > > successful linkage. > > > > > > OK. I missed the fact the these are in common code and net driver is > > > depened on that. > > > So changes makes sense. > >=20 > > It does not make sense to me. > > These are tracepoints for the ethdev driver. > > Why declaring them in the common library? >=20 > Just to gather all mlx5 traces in the single file, to see all available t= racing caps in single view. Better to not export them.