From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id E4CA35A0A
 for <dev@dpdk.org>; Fri, 12 Jun 2015 14:50:57 +0200 (CEST)
Received: by wgme6 with SMTP id e6so24172998wgm.2
 for <dev@dpdk.org>; Fri, 12 Jun 2015 05:50:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=gtvgJ8ET4gv4HH11mE34A7C2tziGWwgQud0Bs2/JB5c=;
 b=DsXKEqipXN8UEJvqI7QN+KFUnCIfXiEEQfWaw7iElJYBwzpT3GULcyPCj7pZwx/9op
 HVfdXyMy6g8F/BQtfotE9kxSVsCUH3mQR22gFN0EjzbNOptfoqs/2HHCAkmFFKbNxZZD
 sokEHFRfgyDRVZ8y01hOW+zvJF031Oeq6ZAj0QfRJlfamkAzmkLIKvBo1FGyxV3fQKQs
 hwUM/yfCqry7eVo1Mh1u2200DCfBPwn9iBQ+byyOoL0QQo1XLGMD5fmIOFVUm+DwZzNQ
 LWX9cEUwp7/fMKeO33qF6H25oQZQuea6xQLd/K/4n1CozJh4ZncmcuCpcZ0qjaLTUGji
 I6Hw==
X-Gm-Message-State: ALoCoQmsM4TuVbJilhmDC1KDKUuF9VK6/SD0clQ5qVr2sIhZ7BkW3KgeJriRcvxpDqj2Pn29COvR
X-Received: by 10.194.84.179 with SMTP id a19mr25698270wjz.29.1434113457777;
 Fri, 12 Jun 2015 05:50:57 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id k2sm2624133wif.3.2015.06.12.05.50.56
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 12 Jun 2015 05:50:57 -0700 (PDT)
Date: Fri, 12 Jun 2015 05:50:57 -0700 (PDT)
X-Google-Original-Date: Fri, 12 Jun 2015 14:50 +0200
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Damjan Marion <damarion@cisco.com>
Message-ID: <2803320.zIVGhAljtF@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <20150526075957.431dae36@urahara>
References: <1432549252-8630-1-git-send-email-damarion@cisco.com>
 <20150526075957.431dae36@urahara>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: fix crash if CQ is not negotiated
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2015 12:50:58 -0000

> > Fix NULL dereference if virtio control queue is not negotiated.
> > 
> > Signed-off-by: Damjan Marion <damarion@cisco.com>
> 
> This is good belt and suspenders thing to have, but did you see early
> patches to check the feature bits and not call this code?
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks