From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 37339ADD5 for ; Fri, 13 Feb 2015 11:53:36 +0100 (CET) Received: by mail-we0-f173.google.com with SMTP id w55so15779574wes.4 for ; Fri, 13 Feb 2015 02:53:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=dUyu5R8OKn/IavTf2AOWZYMESicHNKNhZXEZrLxXFn8=; b=O1MOgmLuJFRfqV5rnvmz6Laryx83XHa19sYBaAwBCd+n+M0F4H1CbuaosTfui57OMg 8tZa7Goa6HZBULQ3NZ77E1fSAPv1JxUmVUKCJid2W/QvRcBAH2eG8EKWzbsQGvdtW7dL BjRfsVbmfcEOU69IBVI+H6dOSQvJl7pIXZcjp4k0lFoABIrqKoMaiK5ONMQV0uGKKp7M 2oyGEyxYTkIbFAluOIzEgeFxWFOPebxMp4qDMp+XDRlZSvwQ9wCEJPOh8EaUBGehjmyi LZOx4Zx5NmLqAqFCSjHJfBtdUKHAwwGaZEs4hE3cLYwMRXsPNjQAMwgixyjsszmT7TjW vdQg== X-Gm-Message-State: ALoCoQmEGWZOB9C8bZ5rX3jAbLglAcvHrwi0t7G2pbiGcTyv0chS0TRZFuvs8GYWKeobsOJWlW3V X-Received: by 10.194.109.36 with SMTP id hp4mr16679114wjb.17.1423824816045; Fri, 13 Feb 2015 02:53:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id hv5sm9587294wjb.16.2015.02.13.02.53.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Feb 2015 02:53:35 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Fri, 13 Feb 2015 11:53:05 +0100 Message-ID: <2803457.ubC8QYJBHj@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54DDD2EE.7070505@redhat.com> References: <6ca22ee1257e34ee2b89f2fb354d6c382b8f3e29.1423644785.git.pmatilai@redhat.com> <12066921.2HzVPH8BW6@xps13> <54DDD2EE.7070505@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 10:53:36 -0000 2015-02-13 12:33, Panu Matilainen: > On 02/13/2015 11:28 AM, Thomas Monjalon wrote: > > 2015-02-13 09:27, Panu Matilainen: > >> On 02/12/2015 05:44 PM, Thomas Monjalon wrote: > >>> 2015-02-11 12:31, Gonzalez Monroy, Sergio: > >>>> From: Panu Matilainen [mailto:pmatilai@redhat.com] > >>>>> On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote: > >>>>>> I think that vhost is being linked in the wrong place (plugins section). > >>>>>> The plugins only get linked when building static libraries. > >>>>>> I think the patch should also remove vhost from the plugins section. > >>>>> > >>>>> Right, so vhost isn't a pluggable driver in the sense that pmds are. I wont > >>>>> claim to be familiar with all this virt-related puzzle pieces :) I'll send an > >>>>> updated patch, I was just looking to fix build in my particular config and > >>>>> ignored the rest. > >>>>> > >>>>> On a related note, shouldn't librte_pmd_bond and librte_pmd_xenvirt be > >>>>> included in the plugins section along with all the other pmds? > >>>>> > >>>> Hi Panu, > >>>> > >>>> Good question :) > >>>> > >>>> I did wonder the same thing not long ago. > >>>> > >>>> I think the reason is that (someone may correct me if I'm wrong) there > >>>> are specific unit tests for those pmds (testing extra API) that require > >>>> them to always be linked against. > >>> > >>> A library is considered as a plugin if there is no public API and it > >>> registers itself. That's the case of normal PMD. > >>> But bonding and Xen have some library parts with public API. > >>> It has been discussed and agreed for bonding but I'm not aware of the Xen case. > >> > >> Fair enough, thanks for the explanation. > >> > >> Just wondering about versioning of these things - currently all the PMDs > >> are versioned as well, which is slightly at odds with their expected > >> usage, dlopen()'ed items usually are not versioned because it makes the > >> files moving targets. But if a plugin can be an library too then it > >> clearly needs to be versioned as well. > > > > Not sure to understand your considerations. > > Plugins must be versioned because there can be some incompatibilities > > like mbuf rework. > > Plugins are version-dependent obviously, but the issue is somewhat > different from library versioning. Plugins are generally consumers of > the versioned ABIs, whereas libraries are the providers. > > > > >> I'm just thinking of typical packaging where the unversioned *.so > >> symlinks are in a -devel subpackage and the versioned libraries are in > >> the main runtime package. Plugins should be loadable by a stable > >> unversioned name always, for libraries the linker handles it behind the > >> scenes. So in packaging these things, plugin *.so links need to be > >> handled differently (placed into the main package) from others. Not > >> rocket science to filter by 'pmd' in the name, but a new twist anyway > >> and easy to get wrong. > >> > >> One possibility to make it all more obvious might be having a separate > >> directory for plugins, the mixed case ccould be handled by symlinks. > > > > I think I don't understand which use case you are trying to solve. > > > > Its a usability/documentation issue more than a technical one. If plugin > DSO's are versioned (like they currently are), then loading them via eg > -d becomes cumbersome since you need to hunt down and provide the > versioned name, eg "testpmd -d librte_pmd_pcap.so.1 [...]" Oh it's clearer now. > Like said above, it can be worked around by leaving the unversioned > symlinks in place for plugins in runtime (library) packages, but that > sort of voids the point of versioning. One possibility would be > introducing a per-version plugin directory that would be used as the > default path for dlopen() unless an absolute path is used. Feel free to update the spec file in pkg/ directory. Thanks