From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9FE9A0C4E; Tue, 2 Nov 2021 14:50:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27AE9411DF; Tue, 2 Nov 2021 14:49:33 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EF50D41169 for ; Tue, 2 Nov 2021 14:49:26 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="231518285" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="231518285" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 06:49:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="577099901" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 02 Nov 2021 06:49:21 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 06:49:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 06:49:20 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 06:49:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 06:49:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fy1C92v5U2hAirORWlan0nRb9E56su3o2lueyiOZKnZvmizJeWb9ODnUmVDTLNBJjh7tF/Yh4k02bE5iyGKKcflK5v3m/v0UDfWd/sB7bHYYnUl3sIuXxTUjBfJGiRSifRPPJuBbezP7F5kxSIbg2VGanG55g2jUb/5r0Dw6i3DysmX2ntRMQNVCR0643hybzgq6FcvhbG2/VR0r2ODaSp17a2B258ec7ySGJgCuw5YK4go8ZRImxJaVr05WaWCdrSWwUz2jyu4Nr74Re8wL4j6jIG1hcSEr4b8SoGJxv+44P6u62OOoUOwYZeK9Fwg8gzU3stNfoP/5+wu+i5ZVAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uCMEx+beGIzyGCnv8wXTHxxw/Igubcrkl6Sx1BddffA=; b=c6FDkWyrlO9dHhyts9+ZhuHci04pKAche1FLQfq5gWlNEWoLcFiG6uxtjQUgH+IaDQ2QDWqbhRSjqmL/qO0kikmcJXsXGuKPHsxjrSg1vFaEiuL2SYuVeSZoP6p63yBrK6luiMuEtWNjz/FmKZXrPfdicZcq2NmOHuoG6GAMcQ8xkZs7I/lCXhVQ4vgMxUGweS0+EJ90tiq4sgThxJvX34yDdOtcfjOe95J6CGePyWfdRDAyhjMDrBEI73gpIQ3Lce1Uqom9oTqg9Si25pLlYf8ulSD8ICncNW12HTZcqClDu2002gcp/RdDZj5NgB254qH741wEvkEO65R6aNNvkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uCMEx+beGIzyGCnv8wXTHxxw/Igubcrkl6Sx1BddffA=; b=B1rRH7z1GStz2XOEubITzupNPXuCsR7EpJN6VwtBmgZRiGOIlJ+wmomFSeK9TkCkkZAzyBSIRaMhngH3bXMdx0PU0sZ3IxgpF3TLfNmB9bdtNIPeJbZ+wDRlVPXqJe3gRtGYF+6GRtWQMkpSBw42kA8QctF00iypH4UhANLg+90= Authentication-Results: oss.nvidia.com; dkim=none (message not signed) header.d=none;oss.nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5914.namprd11.prod.outlook.com (2603:10b6:510:138::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 2 Nov 2021 13:49:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 13:49:18 +0000 Message-ID: <280bf1d2-b5fb-b9ed-1a70-625cc235a649@intel.com> Date: Tue, 2 Nov 2021 13:49:07 +0000 Content-Language: en-US To: Dmitry Kozlyuk , CC: Ori Kam References: <20211019123722.3414694-1-dkozlyuk@nvidia.com> <20211021063503.3632732-1-dkozlyuk@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021063503.3632732-1-dkozlyuk@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Tue, 2 Nov 2021 13:49:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b7715b4-334d-4784-6ce5-08d99e0790d9 X-MS-TrafficTypeDiagnostic: PH7PR11MB5914: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XwY/brX9dskvzOQkW41kwIHHCZhCjfITWQHFrwE5d4cXNQAeS9xTQgtJ0H7Irlknf7mpmXRmFnwBBR0Kpqrlqvh+rCYnjUWHXUs6qaaPB6ENokEqyHvo/nFD8uodsL0qIc3E26TF5kf929w0kDp41U19h7uI7io5WAyt+Bw8gONizG8l2vTqA0eOZsLyUCaHUdqnFK42UZb4TtIWIoHsdIfSiY/YsXA67HXBIXsbcGVo35MWNZX3qKrirB7i8I+dzxFBmQcTB/R1YdsEY1q2KXEONknzRNrtptiGBMWejnuhYuf6gzaz4HkYe7JWPd/IIn13tS0fBP4PSbpr9psVm8YqQBd+bZsJDlgDcfJc8biezy/6D1W4CAPMSleU52P+9p7V41NrcFBu5CEiezKVD4cQMCZkh0rUvDOCVJk27PpEXz7GMDZ7m0DgZXFzALuentxuUeLhmjKsud0X0IoJ8T/SZLWl892SKaeOOzCcfxCbvq/XfhHs3ISZ643MVhA8u5eCgYjMetiy9MPprXc7JxqKYmkfuDj+u+56e+bxfJE0YCZ3fqrrSMY4+c9h5jUFVSXO/yYy5I+KjNSHqo3vhplmRVXYMXNKZmSMd25XskZbAmJdx0wrnw9IEwWqr9uYesuKukNELmeiWkKSc5RHQGTP33RTWwzx+nOctZ5z0Kd4j2XsqqdztoO1a69yLi1BM78RQNDkvfnlmNVQlvHMmzLwPGkDeyIQZgRmQkOdDBIXb/8usmkeOWf59e732wng4Bv2HVhJD9whbUse0hEOMBQJ7649xgSo9UtmY3dGgvAkWtwe9eSuABStQtLrMSBarSB2VI2y5rTHI9EfINWnDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(38100700002)(31686004)(36756003)(4326008)(8936002)(66476007)(66556008)(6666004)(186003)(508600001)(316002)(26005)(31696002)(66946007)(6486002)(16576012)(53546011)(966005)(82960400001)(956004)(44832011)(86362001)(83380400001)(2906002)(2616005)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MU1NVVM3bFJOR1hGVVBTd0p2MVFLRkFoRG12RVF1VisyeUNZMEdZVU81ajRU?= =?utf-8?B?V3AzbE9XcjJYbFBydExrcTdvejhLUDJVSURHbXY2NlZ0eUVTQXRSTWdFclFM?= =?utf-8?B?UFp0aHpoRnVTNEIrSUJKTUVnN3liNFFoU2pOUTVEd2d6ZUpHUUU5ZE1ia3Y0?= =?utf-8?B?cGN4a3NQTHdPalBaR09KQTVDdW0wYWFPUTdBVkVzWXRtK3B3alk4L09NeGtq?= =?utf-8?B?TFlMTjZOcEw3MmF1NDN4ZVgxUEE0NGVpaENKb2wvVGFweWQxSHZjd3dkRVVa?= =?utf-8?B?MTZVcUtDTHByS2NCN2VYeTE5Y21uME92VEc3a1ZpOE1ocUU1eTNwbUs4Q1hN?= =?utf-8?B?RG9yNkM3QWVhT2l5M3BVVi8rdUhVanIrS2VIN0NjN1VzZVFGN1ZZU0FrM3FP?= =?utf-8?B?ZFpwbUZTNk9PYlBzS1dJZU9WblR4NmZTRk05TXVNWk1FbjRKQkZNNG54aHRv?= =?utf-8?B?RVpYQ0RoNU9qckxuUGJPMHJ3U1piM0xNWDVVbWsreDBFMlZmWHVjRCtxKzhC?= =?utf-8?B?eUFMNnp5N3ROZDZDR1BPVzh5YkJaZmNjck5COHdQYjRGMGdmcUZHT3RtTkEr?= =?utf-8?B?VGEzYWhwVXpud3I4dlBlNG1vbitGK0dCQ1k4UXlPQzhiamRjMDhCcHBuN3c5?= =?utf-8?B?VDBPVFJnclE4b3FEbWZTSDN0Z0M2MWtCNUJvbmJodUpQVTRseUkyemd3QUlo?= =?utf-8?B?bkU3eXJ1VjlwRllDZTh1UDNZNURyWGF5QXlqcWZIaXRaNWp2OGtTa1hNK1d3?= =?utf-8?B?OXhDWEx6UmlyNjljMGtpSzRuRGc2QkZDdWZPakRNMVlUMk1xVFZkRnpoanBt?= =?utf-8?B?ZVBna1hvRUMxbzUrM2xVSGcwMElIZjhSZVFmNnB5MmlUUVhycm5SSnFFY3Zu?= =?utf-8?B?akFuTjFXR1NCMXNmN3preTIwbllPNEpNWDczMEErMlhNejk4VmhNWnZ4YlpR?= =?utf-8?B?M2xFMnA4THZYblc0WG1YNktaWkZXcjNNNkZJbFpqZ1J4UjRRU1dCU3ROdWZm?= =?utf-8?B?V1lad2dGWjlnMXhmK0h4TVlDV0NvNlBiZlRVbGFJZXVGeUMzZmw2dm9nTGQr?= =?utf-8?B?VEhiUnU3dHNBRnBOYnphSzFMRVpXMWpoYmIyM1ZZTHB5cEljL3puYmpGMmpN?= =?utf-8?B?S1JIdjV4YjE2dVRmUlhLaUJad28wOWF5Si8wVWZETHUzU1Q3b3BrL1o5TEEr?= =?utf-8?B?WDFtMnc1Q0tiNnVQUVFQRHNZMjdBQ2pHcEViZSt5ZjNkaE1RZ2NWU1BxZHhG?= =?utf-8?B?ak5MdjhISVM2Q29NNDNyUmZBMDY0cVdWREE4QzljM1RnWklTVGEydGRDcElR?= =?utf-8?B?ekJ3Q1JpNzVIeVE3MVV1TDVGcWFXeWY0bExnU1lub00yL1VMZzY2Qjk5U0NO?= =?utf-8?B?Y2U3cW44M3V6VmJmMkoxWFBIVEVxUnZ6MGd4YnJMSzhyaU5FTEdvd2t6Y1hU?= =?utf-8?B?MnJOUVF2N1BsQjByWjNDYjlnOVVTbC9hc29sOWRDSTJacTBzanpOWGh0WkUz?= =?utf-8?B?K0lZbFErNm5kY0x2M0czRDZST1RHMEZ3bDAzb1VKaVpTcWxFdklPSCtvMWZ0?= =?utf-8?B?MW15MTJhUUQvclN6bS9yaHN6QXN0QXVJVE56Wkt4WVByMkVsMmVMNlF0NWZu?= =?utf-8?B?MEF5OHNGSzU5U0hiaDhrUllZUDJIZ1BDRTc3aVY4dVlGNjVYMXFZNGgxR0RE?= =?utf-8?B?WXliQmNXOHorL3hnUmIvcFNkQWV3TmhqSC9ZOVI2aGcxNjB3V3lQTXJoQWlY?= =?utf-8?B?UnBLMWxBOTlweHlHSFk3Z3dBOUM0TDFEMjhzNXdvalVoZWFpZUFBekZSZzNz?= =?utf-8?B?UFFoL2hVeDNiVWJDcGhCRHBtbjBRUVdob05BSnNGL2M1K0JCRWFiMXJBY2xO?= =?utf-8?B?dy91UlBheDVEYmVrUzV0TVE3SVZwMDFKaXBDUnY4NnJ6K1BWV1NjeFNnYzRh?= =?utf-8?B?Wk5PZisvK2hhQkI3SmQwL1JQNzY4VExKS0lraWt5eU1aTmhib0ExTnhKUE1N?= =?utf-8?B?NjlOMDdOeVh3QVdvNjYxZStKUmxiek40RFZVOHRuM05pazh5elRhejBpWXZO?= =?utf-8?B?SWsxZ3VSRXhFeEZnWGdGNGZFTmp6cGdWcTdaRXdxUFM3bFNOL1FpSTFOaWMw?= =?utf-8?B?dmlJRUY4L203QXk5SjhiVWNyYnZBSXprNmtTWjh6dmxYSEZORjd1OE9rR1dx?= =?utf-8?Q?6oNNu8xBggAS0ZKNABd9AIw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b7715b4-334d-4784-6ce5-08d99e0790d9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 13:49:18.8454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V0j1AghsIZONAxwqBDESWENJbNSkOqJ9Fz0Oh9f0HAmw7808izp61DhIIomDRZ0YS/px9zu0CigQ6noTnstmWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5914 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 0/6] Flow entites behavior on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 7:34 AM, Dmitry Kozlyuk wrote: > It is unspecified whether flow rules and indirect actions are kept > when a port is stopped, possibly reconfigured, and started again. > Vendors approach the topic differently, e.g. mlx5 and i40e PMD > disagree in whether flow rules can be kept, and mlx5 PMD would keep > indirect actions. In the end, applications are greatly affected > by whatever contract there is and need to know it. > > Applications may wish to restart the port to reconfigure it, > e.g. switch offloads or even modify queues. > Keeping rte_flow entities enables application improvements: > 1. Since keeping the rules across restart comes with the ability > to create rules before the device is started. This allows > to have all the rules created at the moment of start, > so that there is no time frame when traffic is coming already, > but the rules are not yet created (restored). > 2. When a rule or an indirect action has some associated state, > such as a counter, application saves the need to keep > additional state in order to cope with information loss > if such an entity would be destroyed. > > It is proposed to advertise capabilities of keeping flow rules > and indirect actions (as a special case of shared object) > using a combination of ethdev info and rte_flow calls. > Then a bug is fixed in mlx5 PMD that prevented indirect RSS action > from being kept, and the driver starts advertising the new capability. > > Prior discussions: > 1) http://inbox.dpdk.org/dev/20210727073121.895620-1-dkozlyuk@nvidia.com/ > 2) http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/ > > v4: 1. Fix rebase conflicts (CI). > 2. State rule behavior when a port is not started or stopped (Ori). > 3. Improve wording on rule features, add examples (Andrew). > 4. State that rules/actions that cannot be kept while other can be > must be destroyed by the application (Andrew/Ori). > 5. Add rationale to the cover letter (Andrew). > > Dmitry Kozlyuk (6): > ethdev: add capability to keep flow rules on restart > ethdev: add capability to keep shared objects on restart > net: advertise no support for keeping flow rules > net/mlx5: discover max flow priority using DevX > net/mlx5: create drop queue using DevX > net/mlx5: preserve indirect actions on restart > Hi Dmitry, Can you please rebase this set on latest next-net? There are some changes both in ethdev and mlx5.