From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31D62A00E6 for ; Fri, 9 Aug 2019 11:13:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C38C2082; Fri, 9 Aug 2019 11:13:55 +0200 (CEST) Received: from smtp-4.sys.kth.se (smtp-4.sys.kth.se [130.237.48.193]) by dpdk.org (Postfix) with ESMTP id 889311B19 for ; Fri, 9 Aug 2019 11:13:54 +0200 (CEST) Received: from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-4.sys.kth.se (Postfix) with ESMTP id 35D201C05; Fri, 9 Aug 2019 11:13:54 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-4.sys.kth.se ([127.0.0.1]) by smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RVsYIKSLwl3Q; Fri, 9 Aug 2019 11:13:53 +0200 (CEST) X-KTH-Auth: barbette [130.237.20.142] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1565342033; bh=+YCoUfuNad1p5SHrI1j37eQgehowPoaoEVDCJIGDcU8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ftOHOnFSUCeoHIky7o4tFQVvhETlFk/XXxq2kVMX201rVHXLZMt1JRXKq6eCDflT4 svXGJFQ8YazTo3icKMgWD26+tV46gdPXtsFfSt0jOnaMmBj+c4TOHhNdy+bs0wNHvI 5rwXdytVqgSM9Ow+tElBN+3YFQMRoCt8rlmNs0i0= X-KTH-mail-from: barbette@kth.se Received: from [130.237.20.142] (s2587.it.kth.se [130.237.20.142]) by smtp-4.sys.kth.se (Postfix) with ESMTPSA id C24522930; Fri, 9 Aug 2019 11:13:50 +0200 (CEST) To: pbhagavatula@marvell.com, jerinj@marvell.com, stephen@networkplumber.org, arybchenko@solarflare.com, hemant.agrawal@nxp.com, thomas@monjalon.net, ferruh.yigit@intel.com, bruce.richardson@intel.com, Neil Horman , John McNamara , Marko Kovacevic Cc: dev@dpdk.org References: <20190808085859.796-1-pbhagavatula@marvell.com> <20190809081740.1607-1-pbhagavatula@marvell.com> From: Tom Barbette Message-ID: <2811f2d9-9c85-0eff-6228-e8c5251587a7@kth.se> Date: Fri, 9 Aug 2019 11:13:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190809081740.1607-1-pbhagavatula@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I think the silent breaking is still not solved for DEV_RX_OFFLOAD_RSS_HASH and DEV_RX_OFFLOAD_FLOW_MARK. An old application will still compile without any problem, but the RSS hash will not be written and the app will break... They should be negative. Eg DEV_RX_OFFLOAD_NO_RSS_HASH and DEV_RX_OFFLOAD_NO_FLOW_MARK? Then, regarding the idea, are we sure it's better to add a configuration check/a branch than always copying a few bytes from a warm cache line to a warm cache line? Or some HW could free some internal resources? But drivers are free to ignore it so it is not a problem as opposed to silent breaking. Tom On 2019-08-09 10:17, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new offload flags ``DEV_RX_OFFLOAD_RSS`` and ``DEV_RX_OFFLOAD_FLOW_MARK``. > Add new function ``rte_eth_dev_set_supported_ptypes`` to allow application to > set specific ptypes to be updated in ``rte_mbuf::packet_type`` > > Signed-off-by: Pavan Nikhilesh > Acked-by: Andrew Rybchenko > Acked-by: Jerin Jacob > Acked-by: Hemant Agrawal > --- > doc/guides/rel_notes/deprecation.rst | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 37b8592b6..e4e2a85d7 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -78,3 +78,26 @@ Deprecation Notices > to set new power environment if power environment was already initialized. > In this case the function will return -1 unless the environment is unset first > (using ``rte_power_unset_env``). Other function usage scenarios will not change. > + > +* ethdev: New offload flags ``DEV_RX_OFFLOAD_RSS_HASH`` and ``DEV_RX_OFFLOAD_FLOW_MARK`` > + will be added in 19.11. > + This will allow application to enable or disable PMDs from updating > + ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectively. > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on Rx and > + thereby improve Rx performance if application wishes do so. > + In 19.11 PMDs will still update the fields even when the offloads are not > + enabled. > + > +* ethdev: New function ``rte_eth_dev_set_supported_ptypes`` will be added in > + 19.11. > + This will allow application to request PMD to set specific ptypes defined > + through ``rte_eth_dev_set_supported_ptypes`` in ``rte_mbuf::packet_type``. > + If application doesn't want any ptype information it can call > + ``rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_UNKNOWN)`` > + If application doesn't call ``rte_eth_dev_set_supported_ptypes`` PMD can > + return ``rte_mbuf::packet_type`` with ``rte_eth_dev_get_supported_ptypes``. > + If application is interested only in L2/L3 layer, it can inform the PMD to update > + ``rte_mbuf::packet_type`` with L2/L3 ptype by calling > + ``rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_L2_MASK | RTE_PTYPE_L3_MASK)``. > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on Rx and > + thereby improve Rx performance if application wishes do so. > -- > 2.17.1 >