From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C72942417; Thu, 19 Jan 2023 15:35:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C71E940223; Thu, 19 Jan 2023 15:35:14 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A4670400D5 for ; Thu, 19 Jan 2023 15:35:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BF44D5C0121; Thu, 19 Jan 2023 09:35:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 19 Jan 2023 09:35:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674138912; x= 1674225312; bh=mxrEjFtNybv7SeuPcHRIeFOgfK61uZ+eSoSJijURSs8=; b=s 6B9yZdH5syPcfdIH2Bvf5QN7wx2U0L/4qWI3SrPMgj+khfXzvWpcX7cG0+YSaSbU gltEfE1HFqEOufUnzAI987XcGgfIOOpVpXoD2XF0nOwKohHdqQ8f/caY+dKbvqRp Ecmobp8dE/qLDb/idLV/nxzn+acqMcZeWvCEDbVIC0udUgoOGmMPrDznwYBxtQo3 ecYlwI7rD6g+c9i6FI5cN5wTvUioaQc6/OoOuEhy6XV0i7EkonQTOSaWlUSvO923 Gkw8GozvDzUAUWhurgjvnOfDcx9y+LXgOw1QW7rzfB23QzUq/ghKnnRXdAe6Dc0A H2QHjh6s2TbIxqfVKMjXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674138912; x= 1674225312; bh=mxrEjFtNybv7SeuPcHRIeFOgfK61uZ+eSoSJijURSs8=; b=T +FA//EgOlqZ2ksHft6GUEkBgIKYatlvpUPUAQsx1E+wktBUWehwKf+SXbejQB44h YmMmEbophh9oSgnJRknAMYFqw8ny4lGhUxbEJi1dMr3z/e+nv6tF5Idr9WCcIyyI Z/PzojO6l3+pe5Zhnm1d5hMNkVbf9M7X84i36LcYKSA7CWAfYdKk6KBIfWLJ1734 VNh1MKaTnk1UVK6OltXbry6OMo63t0MTMwuMkLgNjjKNCXUrIyUZ71hiCTLFQ4Yv 1FRYKU8dkW+BHAt1vtWKvh1JXHvq5gUjwb2ZrqbllQB9a+A1WdDmxzNSqoBNgHiN QoGkZD4Qte6OxDSkf+d+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddutddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Jan 2023 09:35:11 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , "lihuisong (C)" Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, liudongdong3@huawei.com, huangdaode@huawei.com, fengchengwen@huawei.com Subject: Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port Date: Thu, 19 Jan 2023 15:35:09 +0100 Message-ID: <2812469.o2A3GueYyp@thomas> In-Reply-To: <04cd6606-e4fc-5ce4-1f08-6a982f1bfd4e@huawei.com> References: <20220825024425.10534-1-lihuisong@huawei.com> <3044549.6YUMPnJmAY@thomas> <04cd6606-e4fc-5ce4-1f08-6a982f1bfd4e@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/01/2023 11:31, lihuisong (C): > =E5=9C=A8 2023/1/18 22:12, Thomas Monjalon =E5=86=99=E9=81=93: > > 11/01/2023 11:46, Ferruh Yigit: > >> On 1/11/2023 10:27 AM, Ferruh Yigit wrote: > >>> On 1/11/2023 12:53 AM, lihuisong (C) wrote: > >>>> =E5=9C=A8 2023/1/11 0:51, Ferruh Yigit =E5=86=99=E9=81=93: > >>>>> Hi Huisong, > >>>>> > >>>>> I haven't checked the patch in detail yet, but I can see it gives s= ome > >>>>> ABI compatibility warnings, is this expected: > >>>> This is to be expected. Because we insert a device state, > >>>> RTE_ETH_DEV_ALLOCATED, > >>>> before RTE_ETH_DEV_ATTACHED for resolving the issue patch 2/5 mentio= ned. > >>>> We may have to announce it. What do you think? > >>> If there is an actual ABI break, it can't go in this release, need to > >>> wait LTS release and yes needs deprecation notice in advance. > >>> > >>> But not all enum value change warnings are real break, need to > >>> investigate all warnings one by one. > >>> Need to investigate if old application & new dpdk library may cause a= ny > >>> unexpected behavior for application. > >>> > >> OR, appending new enum item, `RTE_ETH_DEV_ALLOCATED`, to the end of the > >> enum solves the issue, although logically it won't look nice. > >> Perhaps order can be fixed in next LTS, to have more logical order, but > >> not quite sure if order worth the disturbance may cause in application. > > It is a state with a logical order, so it would be nice to be able to do > > if (state > RTE_ETH_DEV_ALLOCATED) > > but given there is RTE_ETH_DEV_REMOVED later in the enum, not sure it i= s useful. >=20 > The device state is internel. Applications should not access it=20 > directly, right? Right > Currently, ethdev layer or PMD use it by enum value instead of the way li= ke > 'state > RTE_ETH_DEV_ALLOCATED'. Right > But, I encapsulated an API, rte_eth_dev_is_used(), for ethdev or PMD to=20 > call. > I'm not sure if it can help to eliminate our concerns. Yes I think it's OK.