From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1385FA04AE; Tue, 8 Feb 2022 11:58:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B927F410FD; Tue, 8 Feb 2022 11:58:51 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 9CE4D410FC for ; Tue, 8 Feb 2022 11:58:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4C9075C0106; Tue, 8 Feb 2022 05:58:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 08 Feb 2022 05:58:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=N0tHSin+PGQHwT likmHOYhH9cbNsfNdkBwE6L18OxD0=; b=ordQnTK1OKq4/wE9DpNV4aZYszSKp5 3ubnSzlrsKsrdOWOgyDi7k+wW2RafTaPF9z/Atu74nHFeNyHHunr/qFmToO2bLsu DsF5SWDVFci21Ab0iIFfUfASg06/34Sfwo67z3Cy2gqS2eYb2Le24mSNbmiauQIt 4uQtapkJx73gRUitUzjuI4XRLcQ+rco/Rgi7QzbOJ1d0wD1/pnXIs9o1+ubZApX5 RkN6td1jnEFgXvq2ck/C6eCgBdrrEe3JwNxElyJxxddGuvSDDYSeCcSAPRHit0iS 3Iy6iM4cpWWJRXhF/92gDB8c4bM9YVkCADmLdVQAa9jBmXlldvKRud0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=N0tHSin+PGQHwTlikmHOYhH9cbNsfNdkBwE6L18Ox D0=; b=gOciQlYaI8rh2x42aVCsJwY0JkddNcoxH66DWf09AQUXJUTTAFegoAqVB 2saURDEF1rHBOC2vEOT8IkvJJ8JkvLqAFqgtL62ClKYXSoCmQI3nIZBzNpEs9yOW RZ+llirgrCyNxOCROdKKGoxb8Yk9ZtMbJ6ufGiV6EkYRk8yLwSzd2mhmimbxXNZZ pgIT04nIcSfmPtD36+HThTpa2JJQHysPRd64uAKVor2DTbh6n3ytnQ4Z/UNp9V8t 0t8L/kCOfrIgLrKHlKLxGxIrxQaioAfsgPcQRaz7ozoHtDGL7w6mQPbYl3kerGnJ 7CCwL6zMGvW/WOqxdgDnbmuzguJlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheejgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Feb 2022 05:58:45 -0500 (EST) From: Thomas Monjalon To: Jie Zhou Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, aconole@redhat.com Subject: Re: [PATCH v15 09/11] app/test: skip tests that are not supported yet Date: Tue, 08 Feb 2022 11:58:44 +0100 Message-ID: <2812851.e9J7NaK4W3@thomas> In-Reply-To: <1643173844-27341-10-git-send-email-jizh@linux.microsoft.com> References: <1638990000-3228-1-git-send-email-jizh@linux.microsoft.com> <1643173844-27341-1-git-send-email-jizh@linux.microsoft.com> <1643173844-27341-10-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/01/2022 06:10, Jie Zhou: > +#ifdef RTE_EXEC_ENV_WINDOWS > +static int > +test_missing_c_flag(void) > +{ > + printf("emissing_c_flag not supported on Windows, skipping test\n"); Typo here, will change to missing_c_flag [...] > +#endif /*ifdef RTE_EXEC_ENV_WINDOWS*/ I think such comment would be more explicit as /* !RTE_EXEC_ENV_WINDOWS */ when closing a block which is not compiled on Windows. I will change accordingly.