From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 25C743237 for ; Mon, 30 Jan 2017 18:52:42 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id b65so42994903wmf.0 for ; Mon, 30 Jan 2017 09:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=1evERRFkelU0jgVv7K83t1KrP4bMW06wJKTsmSgyhy4=; b=EILLg3ocbOahog3DClmjc0FjUxMRkGx46yyd2FErwCo5igKW3gYwzlnjzqI4IMe6ow krNeFwv7FIPiBJOC2lyqnV555+KthMl1HUyz9OhR2VyHSmmAKH3ZLzIdw6B6Rn+f7TYc rmFJPCj14tyiUGohMYFg5iUHzY4qioN8/MzXhwuZPAOvXHP1DUeBQPY54bji1aI7RuF6 aadWcKIUIioVdEI7bUzgam1XHGeuRtL8B4jHgb24hoD50Wq+msBcrrlVRsBnX6qcRZ+/ QWymP+39QR7ww7D/sR+Fbac5mM0MRMxSkfxXNegVajmAHjYIDBiKRQ+HSnclyFMosz8w GzIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=1evERRFkelU0jgVv7K83t1KrP4bMW06wJKTsmSgyhy4=; b=oi2ulgsmgBXPh6AJzpe2zZAqjgA5BSMD/B5nHn7IBSA5qN3D0obA4Nsu+AhGd4JVmo 4OpB3gwbov2mPg3ZeOFPE9ODrz6Gv1AxY3o0xWLukCi8P/s7yIFBKMFfypiA8FE3SttP PRp5LaHNwl+pcxxMyy0IQptUvT+OJm3sYiomn+JxB04TN+YiH/LG8RZl/WImgF9AJ33n LRT8wp28ZK9zB81/rfyUxgoVhjIs/yHD0sEDm7L+F6wi8nNkntFRZF/Fpdu6jdymUs6i soGvE/AJlQzIbbJMl6Uel9uybbePQHXlg2Zm7hY2pE2sIoYtE4HON4/A1rxJLEZ/r1al pVzw== X-Gm-Message-State: AIkVDXIGTaT/EuE327IXpyq3QaSnuLtfFFVY2pq1n+zsVAbBO7aCmK9v2MeUtcgEujBH5pN4 X-Received: by 10.223.135.244 with SMTP id c49mr19037215wrc.135.1485798761837; Mon, 30 Jan 2017 09:52:41 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id k70sm19933961wmc.3.2017.01.30.09.52.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 09:52:40 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit , Jianfeng Tan Cc: dev@dpdk.org, john.mcnamara@intel.com, yuanhan.liu@linux.intel.com, stephen@networkplumber.org Date: Mon, 30 Jan 2017 18:52:39 +0100 Message-ID: <2816494.kdcLa2jDNL@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <66ee7e72-95a3-1e31-278c-b6823168de6c@intel.com> References: <1485243248-27082-1-git-send-email-jianfeng.tan@intel.com> <1485243248-27082-4-git-send-email-jianfeng.tan@intel.com> <66ee7e72-95a3-1e31-278c-b6823168de6c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] doc: remove ABI changes in igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 17:52:42 -0000 2017-01-24 13:35, Ferruh Yigit: > On 1/24/2017 7:34 AM, Jianfeng Tan wrote: > > We announced ABI changes to remove iomem and ioport mapping in > > igb_uio. But it has potential backward compatibility issue: cannot > > run old version DPDK on modified igb_uio. > > > > The purpose of this changes was to fix a bug: when DPDK app crashes, > > those devices by igb_uio are not stopped either DPDK PMD driver or > > igb_uio driver. We need to figure out new way to fix this bug. > > Hi Jianfeng, > > I believe it would be good to fix this potential defect. > > Is "remove iomem and ioport" a must for that fix? If so, I suggest > re-think about it. > > If I see correctly, dpdk1.8 and older uses igb_uio iomem files. So > backward compatibility is the possible issue for dpdk1.8 and older. > Since v1.8 two years old, I would prefer fixing defect instead of > keeping that backward compatibility. > > Jianfeng, Thomas, > > What do you think postponing this deprecation notice to next release, > instead of removing it, and discuss more? > > > And overall, if "remove iomem and ioport" is not a must for this fix, no > problem to remove deprecation notice. I have no strong opinion here. Jianfeng, do you agree with Ferruh?