From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 889152C5; Thu, 20 Apr 2017 23:43:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1924C20906; Thu, 20 Apr 2017 17:43:52 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 20 Apr 2017 17:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Mj0dX552xDQ8yNT ktYbUZ6+y61rSvu2Lvw6qgJRhjVs=; b=VhIN2WJcr7XsCCI+39M5CsujDKbf7Jl xhdtfW0fdhhBFTKsQZfvj5eZkY0BBQAuu7/SPQ/nS6+hVXuO/TZM1mAxxhTYEah7 +gw9yzhxjIjOuYAC+xISoEa5aSkw14MJU3SQ3wBshqJSZUeSNV/NDRUrNcyRqlBH mCslfyutl8oc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Mj0dX552xDQ8yNTktYbUZ6+y61rSvu2Lvw6qgJRhjVs=; b=hafaEV6U SZgE4SZ9yeoreLw6ejpNrxPSwL6IL5rFr0eJTeOa69l6s2SJYsK33f2suj5N0U2Z j9ePwQ725qT07SetUrJYLFCaDo6T5+EAeIBv77Vj65p406ZP/3ruA5XKCDXVpYY1 HUFdh0w7qdwX6LeitSWU3zk8jbk5cUBI4/lvU+KMcJrZKaH7PVUGaxa1WZc4Alyg 850ueHL9NGO1hLAgmzmEtCz4XbvlfQSyKd86uu0/06IF00HMJn7WnECC72p9LT0V GRnmpXRCITbzHuPAlYOkWuSNAi7WrSLw+8qx8axlrv7E0DuwYkDLXOQtcw10V3Ed z6hi3n0yTvuVHA== X-ME-Sender: X-Sasl-enc: tUjtgC2k1WGbZp74AlMIF6+Nbz76ss87bMeYCVgHkcIs 1492724631 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 912C424457; Thu, 20 Apr 2017 17:43:51 -0400 (EDT) From: Thomas Monjalon To: Wei Dai Cc: stable@dpdk.org, thomas.monjalon@6wind.com, harish.patil@cavium.com, rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com, dev@dpdk.org Date: Thu, 20 Apr 2017 23:43:50 +0200 Message-ID: <2816605.jEqPTYToiQ@xps> In-Reply-To: <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> References: <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 21:43:53 -0000 13/04/2017 10:21, Wei Dai: > some customers find adding mac addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++++-- > drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------ > drivers/net/e1000/base/e1000_api.c | 2 +- > drivers/net/e1000/em_ethdev.c | 6 +++--- > drivers/net/e1000/igb_ethdev.c | 5 +++-- > drivers/net/enic/enic.h | 2 +- > drivers/net/enic/enic_ethdev.c | 4 ++-- > drivers/net/enic/enic_main.c | 6 +++--- > drivers/net/fm10k/fm10k_ethdev.c | 3 ++- > drivers/net/i40e/i40e_ethdev.c | 11 ++++++----- > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++---- > drivers/net/ixgbe/ixgbe_ethdev.c | 27 ++++++++++++++++++--------- > drivers/net/mlx4/mlx4.c | 18 +++++++++++------- > drivers/net/mlx5/mlx5.h | 4 ++-- > drivers/net/mlx5/mlx5_mac.c | 16 ++++++++++------ > drivers/net/qede/qede_ethdev.c | 6 ++++-- > drivers/net/ring/rte_eth_ring.c | 3 ++- > drivers/net/virtio/virtio_ethdev.c | 13 +++++++------ > lib/librte_ether/rte_ethdev.c | 15 +++++++++------ > lib/librte_ether/rte_ethdev.h | 2 +- > 20 files changed, 100 insertions(+), 70 deletions(-) Please, could you rebase and add changes to newly introduced drivers? Thanks