From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A64AA0353; Tue, 19 Nov 2019 23:30:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A2EDA69; Tue, 19 Nov 2019 23:30:24 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 2BB89237 for ; Tue, 19 Nov 2019 23:30:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id EB00C51B; Tue, 19 Nov 2019 17:30:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 19 Nov 2019 17:30:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=epW79oVyt1epBn0fZ+/vIomzydF1kSOUhz3Bz/GG1FI=; b=Qs3+zi1vL/NX FsoZZgyJ3BL8n8+UT+QDQDYfBRUj/H3sEvJCa75xJ/Z0A7qC7cwrOampi9gNBMfX xyHD9FKZ6c90BF80jtSk56U8rOS5ZUzuUJ4CXrZaY/Zy7bsQ73pM8UOzUcV74Nxf AAvjzrDl6b+7gUOyvpgvjlTPNDxKaPo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=epW79oVyt1epBn0fZ+/vIomzydF1kSOUhz3Bz/GG1 FI=; b=tnCliIGhV9DCvZl1CdwogNXcTIAq14OteEa/fst1IMdIPnju92DB4Prqj AOHdt1ioJU0FIuTVfkAnP8v+GGY26fdZ4gI7tkYqF4VWJBhkcVDfCblcrrxPzZ4Q JVe440U+oOA9fdvdsdIDSIYGBR/AHwvcxwowVjkWz5rqAdieG/eASRXepiivbap6 98qOfTTp/LdeDNgwds4y8hzf7aXXeEXuUexJxtrRP2pJjWBFg1YFIpSkpCvJfZ73 tGJEYuOjt3joK2JtoLT47rDszxvlK0BCQJi3DzBM3UMj5UooquxTR+mcycU+DNxM yD+WrtFeLqaG9CYdxBbWi0ESESTYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudegkedgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B81C80066; Tue, 19 Nov 2019 17:30:18 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: Shahaf Shuler , "olivier.matz@6wind.com" , "dev@dpdk.org" Date: Tue, 19 Nov 2019 23:30:15 +0100 Message-ID: <2817003.Afhorg6P4o@xps> In-Reply-To: <20191119082515.41848e4e@hermes.lan> References: <20191118100247.74241-1-shahafs@mellanox.com> <20191119082515.41848e4e@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/11/2019 17:25, Stephen Hemminger: > On Tue, 19 Nov 2019 15:23:50 +0000 > Shahaf Shuler wrote: > > > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > > > 18/11/2019 11:02, Shahaf Shuler: > > > > struct rte_pktmbuf_pool_private { > > > > uint16_t mbuf_data_room_size; /**< Size of data space in each > > > mbuf. */ > > > > uint16_t mbuf_priv_size; /**< Size of private area in each mbuf. > > > */ > > > > + uint32_t reserved; /**< reserved for future use. */ > > > > > > Maybe simpler to give the future name "flags" and keep the comment > > > "reserved for future use". > > > > I'm am OK w/ changing to flags. > > If Olivier accepts maybe you can change while applying? > > After the Linux openat experience if you want to add flags. > Then all usage of API needs to validate that flags is 0. Sorry Stephen, I don't understand what you mean. Please could you explain?