From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67A9AA00BE; Thu, 10 Mar 2022 21:23:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 381454113F; Thu, 10 Mar 2022 21:23:42 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 4C6DA4113E for ; Thu, 10 Mar 2022 21:23:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A4C735C0181; Thu, 10 Mar 2022 15:23:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 10 Mar 2022 15:23:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=RhUUg9lG9lBC6Q v8D3NWOFaG2ies4TESBUKwyylAivY=; b=GUzZod26kAR/k9S3dbYvlDmSbbpACS RF7C4oMdoNH7TsV8AUAwesMu60Oom9ir4u1T1tBQqKq4berLHsgNfo8Ouy2xwCXt jym+D6pLOgQrgpocFSgbVrpX3Z86tcNhvS1M8mkBylgRIFzGcEnlFSVDCjjasJZr 7nStotGa3xumthvKWqfwcOOqFBxJVeel97F0pi2jmNUzoSFS2XXrA0VAxSxEFig8 M2+jvS20SuuV3rcFtjjRz3P7pHFqZ5P+jEXPWiy8pWeSdk4u6jdBGyquGgcPKXcu Yg9aM4MogArchRJDnhAfeFiJ6Z1v4UAfS8N6msrRb1NKsCzW77UrL6Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RhUUg9lG9lBC6Qv8D3NWOFaG2ies4TESBUKwyylAi vY=; b=aLJQoyf+1PKghbOgee+3gWwSzyjpgnIXAwy5H+s0aITg2ZFIs7tsBGGxQ y6YxSpcl+7/Kmf1nssb/oANu16Vrdy0B0GdT26jZrFaVN5oz0+wZ5ytJNCcokqaP BbhCDJ8+I8iSuSbwTSY9eLCsI3+qSZBteURd1Ad7CEw3S64cwcbUfaaEIZN7O4tR k1S/shbR7NU1yRZFLsmlrUF95vivsDKKCTXZlJdNQH2tMOEH8oCjqNkYkrQKDwiR kj3GKCQ08wSQg7V6wFjLa50AU/7qz1dU3CvRK5HvDRFBqg6jWmizj5PaS4CcMIur IdqgkcSvu0aK2VfWVEy6Ve+vreCjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvtddgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Mar 2022 15:23:39 -0500 (EST) From: Thomas Monjalon To: Elena Agostini Cc: dev@dpdk.org Subject: Re: [PATCH v1] gpu/cuda: set unused gdrcopy functions arguments Date: Thu, 10 Mar 2022 21:23:38 +0100 Message-ID: <2817309.e9J7NaK4W3@thomas> In-Reply-To: <20220310000650.25171-1-eagostini@nvidia.com> References: <20220310000650.25171-1-eagostini@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/03/2022 01:06, eagostini@nvidia.com: > From: Elena Agostini > > Without enabling gdrcopy, dpdk build has warnings about > unused gdrcopy functions input parameters. As developers we should test with --werror option given to meson, so we don't miss such details. This is what the script devtools/test-meson-builds.sh does. > This patch set them to __rte_unused . > > Fixes: 24c7759 ("gpu/cuda: map GPU memory with GDRCopy") Let's keep this casing of GDRCopy in the new title. > Signed-off-by: Elena Agostini > --- > int > -gdrcopy_pin(gdr_t *gdrc_h, __rte_unused gdr_mh_t *mh, uint64_t d_addr, size_t size, void **h_addr) > +gdrcopy_pin(__rte_unused gdr_t *gdrc_h, __rte_unused gdr_mh_t *mh, __rte_unused uint64_t d_addr, __rte_unused size_t size, __rte_unused void **h_addr) While at it, break the too long line. It seems my compiler is smart enough to not require the unused attribute for parameters used in another branch of #ifdef. But it is probably required for some old compilers. Applied, thanks.