Re: [dpdk-dev] [PATCH v5 6/8] devtools/test-null: load all drivers from directory

[Thomas Monjalon <thomas@monjalon.net>]

20/10/2020 10:37, Bruce Richardson:
> On Mon, Oct 19, 2020 at 06:58:32PM +0200, Thomas Monjalon wrote:
> > 15/10/2020 17:05, Bruce Richardson:
> > > Rather than specifying specific drivers in the driver directory to load, we
> > > can just pass in the whole driver directory to the "-d" EAL flag, causing
> > > all drivers to load. This makes the load of driver independent of any
> > > specific driver names.
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > --- a/devtools/test-null.sh
> > > +++ b/devtools/test-null.sh
> > >  if ldd $testpmd | grep -q librte_ ; then
> > >  	export LD_LIBRARY_PATH=$build/drivers:$build/lib:$LD_LIBRARY_PATH
> > > -	libs='-d librte_mempool_ring.so -d librte_pmd_null.so'
> > > +	libs="-d $build/drivers"
> > 
> > In this case, can we remove $build/drivers from LD_LIBRARY_PATH?
> >
> I think it's safer to keep it, as some drivers depend upon others, e.g.
> many NIC/crypto/etc drivers depend upon pci or vdev bus drivers. Therefore
> depending on the order in which the drivers load, they will have unmet
> dependencies which will be found by looking in LD_LIBRARY_PATH

Yes but this test is only for null PMD so I did the change.