From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 754C12904 for ; Wed, 23 Mar 2016 09:47:08 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id r129so125685246wmr.1 for ; Wed, 23 Mar 2016 01:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=/XpooGf1KwW8meFiYHK0LLn6pNIb+4XsdWO/BosVS+I=; b=stOS8x3xMQY/v4ex59KE00apkqwIfuI1Ew1ch2iQRw8Kjz7HfOZilr4qq98w73hxNv m2v18IorSw4fUAIvcXEZrd/1kXH6NNDNyVi5kyt+LoVsn78pYXTLHRCQUdH4cglTaLjA FTUiJY/KePS8PH0XzqddGlP1piTaYl+6YSkx3K1j8p6vBsCNrGRzzwYuWuKu+3pmnfMv TvFqmf+eOmDpid8Ban9boXdZltmfTwxn1YZJaxccCovSvkCk7NR30AzkspnPg7CEahwx MiQzfqCYo814TsWKmBHCXcHtd/k+3i5seDM2/jffFnmAjC88mWKehGPDH2CIET2fQdRh VuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=/XpooGf1KwW8meFiYHK0LLn6pNIb+4XsdWO/BosVS+I=; b=ht/OpdbV4Q+bTgWSPrW7RqXYXUA580rRGKPzhYLuY4ynL9MDNwVT3XpGxtIoMxag7o fJfvFIs6K3+DorRVswTOENW7bse5d5v3GOwKHRQ1QMzU8k9M19JL4uo8j6wgUHjmA/5r H9ssalc9SkEVvcQkyy7bvVil1c6gpEJZ5bylnC5EjykCTVoPFaCw7QdGFjlME/o+P2Lb AZjGtsWYhP/CKN9yulxanKTvJkH9EBHZHE73+B8c7KaCkP3N0uVtxgM3PWz9FaTdIAYw Opq+W8ku3IwUUyS6EznT4uvY1/V4hEP9zfxc8c+HjAKaV+BCC4r1EWd2WAYdlec2SeUy DVpw== X-Gm-Message-State: AD7BkJID6RQYX1jd8VAlA3vq7LESeDs++vgp3RFag19l1zPOWGuXJ69gmNLFHehINUvf0kUZ X-Received: by 10.28.34.69 with SMTP id i66mr25451483wmi.91.1458722828311; Wed, 23 Mar 2016 01:47:08 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id 8sm21093352wmk.13.2016.03.23.01.47.07 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 01:47:07 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" Cc: dev@dpdk.org, "Zhang, Helin" Date: Wed, 23 Mar 2016 09:45:26 +0100 Message-ID: <2819574.tiGSjDHHFB@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8DDB904@SHSMSX104.ccr.corp.intel.com> References: <1457580346-18550-1-git-send-email-jingjing.wu@intel.com> <2777481.Ou9arTG791@xps13> <9BB6961774997848B5B42BEC655768F8DDB904@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for input selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 08:47:08 -0000 2016-03-23 00:42, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-21 14:18, Jingjing Wu: > > > This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, > > > RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended > > > struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering by > > > tos, protocol and ttl. > > [...] > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -22,10 +22,6 @@ Deprecation Notices > > > * The ethdev structures rte_eth_link, rte_eth_dev_info and rte_eth_conf > > > must be updated to support 100G link and to have a cleaner link speed > > API. > > > > > > -* ABI changes are planned for struct rte_eth_fdir_flow in order to > > > support > > > - extend flow director's input set. The release 2.2 does not contain > > > these ABI > > > - changes, but release 2.3 will, and no backwards compatibility is planned. > > > > The changed structures are part of rte_eth_fdir_flow. > > So this deprecation notice apply to this patch. > > > > > * ABI changes are planned for rte_eth_ipv4_flow and rte_eth_ipv6_flow > > to > > > include more fields to be matched against. The release 2.2 does not > > > contain these ABI changes, but release 2.3 will. > > > > These are the structures changed in this patch. > > I think this section must be also removed. > > This deprecation notice is not raised by me. It is raised by rahul.lakkireddy@chelsio.com at commit 954f1545a1ab. > So, I'm not sure if it is OK for me to remove it in my patch. It does not matter who raised the notice. Your patch match with it. Please remove it.