From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] eal: fix msvc conditional compile of rte atomic thread fence
Date: Wed, 08 Nov 2023 14:40:42 +0100 [thread overview]
Message-ID: <2819904.AiC22s8V5E@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EFEF@smartserver.smartshare.dk>
08/11/2023 09:27, Morten Brørup:
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Tuesday, 7 November 2023 21.00
> >
> > MSVC does not expose legacy atomics. When the legacy atomics were
> > excluded rte_atomic_thread_fence was also unintentionally excluded
> >
> > Adjust the conditional compilation check to expose
> > rte_atomic_thread_fence.
> >
> > Fixes: 27da6a123414 ("eal: hide legacy atomics API for MSVC")
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks.
prev parent reply other threads:[~2023-11-08 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 20:00 Tyler Retzlaff
2023-11-08 8:27 ` Morten Brørup
2023-11-08 13:40 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2819904.AiC22s8V5E@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).