From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id A33469A81 for ; Thu, 4 Feb 2016 22:33:38 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id p63so1424965wmp.1 for ; Thu, 04 Feb 2016 13:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=vH4qJmdWNnjVoPwOwp/PRMFZezN8wFwN1xou4zLAkTY=; b=18gmDO2FWo+NyDphe/xSolwNhutfwKXuvlEJJVEF/RxloaPAdtKS1mD4WyY1e6FfOF NDVFPmyyxwxGXPYpCIT17vqyPev1LRphF3pXvRrjqqTZywMFmedtUQDwOq2gp/FKk96b 2q7zkrULTJ13StgJ63XAJeQYq4dpcy5jstog2cRE0562IpLhKmrmrtXwkHiZ1D+xvVPp KAygCfBCXw2vhinjZGVQUwxRcfpyASGj29fFK3DZWHNrkhQW+/MBRdqzEAJdkutXfU6W melGCgELK+UdyzxkUUTBo4WZAoxc/damWhL/sin06cS+7ZEbSB7QxVrHWj1S9YfFDKTg cChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vH4qJmdWNnjVoPwOwp/PRMFZezN8wFwN1xou4zLAkTY=; b=FOf8vD3T3CTRUU/CDxNh0uU/kUTItlKj0C+DqOPrmxhFaQ1kA5CFCXDcPz/NFRZb76 XQRwxhF9jtGkpoE9OAW01gH+T54oc4qLUSVL7C1t0cjC4+hmr7G7aduqO2GAhSPkJ9yh nmX9Yd/5g9jR44FTIHPxiXPJupUELZaiOlIz5RInN1wUXuSnXRI5EXivXkyjaasyY8Ti /w89OB1anLOyKIPjTQPdgGuB7iyVV51BDfasT0ra70wrTDz+gvbaoBvdibbflIWEwjb8 jcnzSkShuzAHufijRgp2pO8xw9M/rIjGhSa/7z+YjhClZEDcdhOIbutpsvEPv3toT2+R OLvQ== X-Gm-Message-State: AG10YOSsJboGTePFgCRnyUGsoru71cRdrIdxbMi9MU6/s467XQlchp/tPk85v1IYXw8Wm2UD X-Received: by 10.194.114.164 with SMTP id jh4mr10327708wjb.153.1454621618466; Thu, 04 Feb 2016 13:33:38 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id c26sm28108755wmi.24.2016.02.04.13.33.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Feb 2016 13:33:37 -0800 (PST) From: Thomas Monjalon To: Zhihong Wang Date: Thu, 04 Feb 2016 22:32:23 +0100 Message-ID: <2821262.qCsjkLddf6@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1454551954-45356-1-git-send-email-zhihong.wang@intel.com> References: <1454551954-45356-1-git-send-email-zhihong.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/x86: Fix build with clang for old AVX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 21:33:38 -0000 2016-02-03 21:12, Zhihong Wang: > When configuring RTE_MACHINE to "default", rte_memcpy implementation > is the default one (old AVX). > In this code, clang raises a warning thanks to -Wsometimes-uninitialized: > > rte_memcpy.h:838:6: error: > variable 'srcofs' is used uninitialized whenever 'if' condition is false > if (dstofss > 0) { > ^~~~~~~~~~~ > rte_memcpy.h:849:6: note: uninitialized use occurs here > if (srcofs == 0) { > ^~~~~~ > > It is fixed by moving srcofs initialization out of the condition. > Also dstofss calculation is corrected. > > Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512") > > Signed-off-by: Zhihong Wang > Reported-by: De Lara Guarch, Pablo Applied, thanks