From: Thomas Monjalon <thomas@monjalon.net>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: dev@dpdk.org, "Hunt, David" <david.hunt@intel.com>,
alan.carew@intel.com, liang.j.ma@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled
Date: Thu, 21 Nov 2019 00:53:11 +0100 [thread overview]
Message-ID: <2822214.ZKj97Fs1sa@xps> (raw)
In-Reply-To: <ade49b7a-94ec-cc1b-e234-bec944c63a3b@intel.com>
14/11/2019 17:23, Hunt, David:
> Hi Mattias,
>
> On 14/11/2019 14:10, Mattias Rönnblom wrote:
> > Calling pstate's or acpi's rte_power_freq_up() when on the highest
> > non-turbo frequency results in an error, if turbo is disabled. The
> > error is in the form of a return code and a RTE_LOG() entry on the ERR
> > level.
> >
> > According to the API documentation, the frequency is scaled up
> > "according to the available frequencies". In case turbo is disabled,
> > that frequency is not available. This patch's rte_power_freq_up()
> > behaviour is also consistent with how rte_power_freq_max() is
> > implemented (i.e. the highest non-turbo frequency is set, in case
> > turbo is disabled).
> >
> > Fixes: 445c6528b55f ("power: common interface for guest and host")
> > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > ---
>
> Thanks for the patch, I can repeat the issue without the patch, and
> after applying the patch, I no longer get the error message. So:
>
> Tested-by: David Hunt <david.hunt@intel.com>
>
> It might be worth clarifying in the commit message that "turbo
> disabled"actually means "turbo enabled in the bios, but disabled via the
> power library", but that's a small point.
>
> Acked-By: David Hunt <david.hunt@intel.com>
Applied with change in commit log, thanks.
next prev parent reply other threads:[~2019-11-20 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 14:10 Mattias Rönnblom
2019-11-14 16:23 ` Hunt, David
2019-11-20 23:53 ` Thomas Monjalon [this message]
2019-11-15 12:23 ` Liang, Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2822214.ZKj97Fs1sa@xps \
--to=thomas@monjalon.net \
--cc=alan.carew@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=liang.j.ma@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).