From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57B3FA04C7; Thu, 21 Nov 2019 00:53:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EE21271; Thu, 21 Nov 2019 00:53:17 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4042A23D; Thu, 21 Nov 2019 00:53:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7748721FBA; Wed, 20 Nov 2019 18:53:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Nov 2019 18:53:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Fw+ktH3SP8H3wHWpd3kFvvEv0/SFavi+pxit+0Lt7+U=; b=Cmz7KyHNIIaX WNF9Mz3Yq8tTOvj9kJkPrqecbEwnS5bIv6KB6fEMsYyKKt5RHRRWXmgviWysQAvR ZRrchXi+wQgwbWor3lAUTf1XzXyR4Ui+FzmEUZoAaLnO4qwe8wFo3EcCeBFttlmH FTgHgkmIA8R6xF1ktPQx9adXcweo7xU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Fw+ktH3SP8H3wHWpd3kFvvEv0/SFavi+pxit+0Lt7 +U=; b=VItBqfqZL79NCYbJ9BtglShZMPJaL3DmTn1nzxCrt9Y8NbsPunOge0EES DORTpB/hxUnWsh5xic6EdxYj2ziB2NxfCdMnxhnU68S+69PT/T3MBuVDuSftYPHF TEOOpsh+HpFgCRrmdVgy2lwFTtcnwsGhiZOllrIl2w/PHeZZk4iUIT/vw0wDI2uD dXGsw8guet5F5zt/65UEk9tgcHvSMbzqrZitJLVYFgJJHPA01ZRa2yAbn4Gmbt+z IrTDPr5DI8rg+iRNCQ0Lo7GeE1U7higI2DmHnfuCSbdA742g5W+G/ep1kYM0i4mD DjSNuzWXiREsAp1vT9kkawptWQnug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehuddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B2E4C306005E; Wed, 20 Nov 2019 18:53:12 -0500 (EST) From: Thomas Monjalon To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, "Hunt, David" , alan.carew@intel.com, liang.j.ma@intel.com, stable@dpdk.org Date: Thu, 21 Nov 2019 00:53:11 +0100 Message-ID: <2822214.ZKj97Fs1sa@xps> In-Reply-To: References: <20191114141036.31317-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/11/2019 17:23, Hunt, David: > Hi Mattias, >=20 > On 14/11/2019 14:10, Mattias R=F6nnblom wrote: > > Calling pstate's or acpi's rte_power_freq_up() when on the highest > > non-turbo frequency results in an error, if turbo is disabled. The > > error is in the form of a return code and a RTE_LOG() entry on the ERR > > level. > > > > According to the API documentation, the frequency is scaled up > > "according to the available frequencies". In case turbo is disabled, > > that frequency is not available. This patch's rte_power_freq_up() > > behaviour is also consistent with how rte_power_freq_max() is > > implemented (i.e. the highest non-turbo frequency is set, in case > > turbo is disabled). > > > > Fixes: 445c6528b55f ("power: common interface for guest and host") > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > > Cc: stable@dpdk.org > > > > Signed-off-by: Mattias R=F6nnblom > > --- >=20 > Thanks for the patch, I can repeat the issue without the patch, and=20 > after applying the patch, I no longer get the error message. So: >=20 > Tested-by: David Hunt >=20 > It might be worth clarifying in the commit message that "turbo=20 > disabled"actually means "turbo enabled in the bios, but disabled via the= =20 > power library", but that's a small point. >=20 > Acked-By: David Hunt Applied with change in commit log, thanks.