From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pipeline: use unsigned constants for left shift operations
Date: Sun, 13 Mar 2016 16:19:50 +0100 [thread overview]
Message-ID: <2826033.PWulAmGijI@xps13> (raw)
In-Reply-To: <596c08913453daea0e9c98f25befba923a961216.1457617795.git.pmatilai@redhat.com>
2016-03-10 15:49, Panu Matilainen:
> --- a/examples/ip_pipeline/pipeline/pipeline_routing.c
> +++ b/examples/ip_pipeline/pipeline/pipeline_routing.c
> @@ -319,7 +319,7 @@ app_pipeline_routing_add_route(struct app_params *app,
> if ((depth == 0) || (depth > 32))
> return -1;
>
> - netmask = (~0) << (32 - depth);
> + netmask = (~U0) << (32 - depth);
Typo: should be 0U.
prev parent reply other threads:[~2016-03-13 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 13:49 Panu Matilainen
2016-03-10 14:27 ` Dumitrescu, Cristian
2016-03-13 15:23 ` Thomas Monjalon
2016-03-13 15:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2826033.PWulAmGijI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).