From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id B73613989
 for <dev@dpdk.org>; Sun, 13 Mar 2016 16:21:11 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id p65so72700289wmp.1
 for <dev@dpdk.org>; Sun, 13 Mar 2016 08:21:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=0ztw1PdsZjmvO3g5VFcRYHIBUyloHbkvWou2nXsPuVU=;
 b=yra1uCQH8+1ekxDd4YymaUBnX4OTQZucu1h18YkIqkMk4yNje9pZHvpFUlwsT6f3F1
 O/1Jx2f3pPmbxEk+50fiPUbfYUVFJcmAgJ+fc7zst83eC64YJvObI0Q6rge85q8Q5ZK0
 Jc0XG3wmo/Kxd2qC/hJGaxLH88pdTIRtCvByXpli2uSRYtqG+w5s/VplTA2k75n24KCL
 sUIO90uDx7aPaJUz2YyucDm8uylESfAhleX5QFashC4LlSG4S77RxH+ItLX7uKOG5dpi
 2Y/6AgixyS+j3+WpY7NpBnN9HOhyG2G8LE5uwkD8D6xdHStvGN4QJkk3i5UaNNJyYLh3
 8tqQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=0ztw1PdsZjmvO3g5VFcRYHIBUyloHbkvWou2nXsPuVU=;
 b=k8Mu+fGHrLjThxlKc5KUyhLx29ZalduNqWSQfS6HMwXx09Y6R9DdzYHeN8WF9nr3EW
 LkMA6QLT+gMhc6XuvUqzkNqbHDQ0689qNtKIxZHcn7fFJ0b6K8xe3gW/Fvd69MWkSiQx
 cMvSmwguakj7sWQO50JwQarsSF8ypTsOpTa/dKIaVwl5EElP4m7C/Ri50AK23b+MdB5T
 Wd/P5jb7ljSyJCuQyiX9jz80ik0w7Enub8Yh6NsvyRvxUJ4aeORwLuBh65k61wGpDS0f
 mFhr9Y9nDb5aZKPWmBXn0RK7GOi1ql5Wt+wOoPkHb4Y0AIg8jU4FSydNIBR9ZXJ/GJth
 bcWw==
X-Gm-Message-State: AD7BkJLwoTDNCB+++F5cS41PXINz2xu66onghAiIfm8AghnXE9TTdOTFwIlKO9e2j0iUKGFB
X-Received: by 10.194.71.177 with SMTP id w17mr22659040wju.36.1457882471578;
 Sun, 13 Mar 2016 08:21:11 -0700 (PDT)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
 by smtp.gmail.com with ESMTPSA id av3sm18121075wjc.44.2016.03.13.08.21.10
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 13 Mar 2016 08:21:11 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Date: Sun, 13 Mar 2016 16:19:50 +0100
Message-ID: <2826033.PWulAmGijI@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <596c08913453daea0e9c98f25befba923a961216.1457617795.git.pmatilai@redhat.com>
References: <596c08913453daea0e9c98f25befba923a961216.1457617795.git.pmatilai@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] pipeline: use unsigned constants for left
	shift operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2016 15:21:11 -0000

2016-03-10 15:49, Panu Matilainen:
> --- a/examples/ip_pipeline/pipeline/pipeline_routing.c
> +++ b/examples/ip_pipeline/pipeline/pipeline_routing.c
> @@ -319,7 +319,7 @@ app_pipeline_routing_add_route(struct app_params *app,
>                 if ((depth == 0) || (depth > 32))
>                         return -1;
>  
> -               netmask = (~0) << (32 - depth);
> +               netmask = (~U0) << (32 - depth);

Typo: should be 0U.