From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6B81B374 for ; Mon, 19 Jun 2017 23:04:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0FC7E20D8D; Mon, 19 Jun 2017 17:04:10 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 19 Jun 2017 17:04:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=GcuOZX/qlSRgb2G RmRc6m7eIr3jS2UHYnrSrCZqzsv0=; b=SUGeH0D94UDD5oKO2hBsIP8Ar144Bsx SA+0HD1WVQqAkgJJlikU0im+TNjDIH5ayUuMMjP33j+ddHplTSW7BzhjnmyNoAVU muArK+5fyMyM4Cm5x1GxRaOtnp0Qda9khm2Gn/AccfltJ/mj9EEwmjZe0nHT+PN2 cV5pxp8XoInA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=GcuOZX/qlSRgb2GRmRc6m7eIr3jS2UHYnrSrCZqzsv0=; b=T9nK/7Y9 GE3qx5Nf2B/ZMJKEev/9FBy90mZ07ZgjLcwubqu7cF4hl2TIPPIX0derYNrXrZ9N T2QaZOrEh8tVeNaWCfGh8T3ZYvpuaGU0wO9BGPAtAjW+WOnuSjo7Xa6yxMDhENRV iiyTHgDwlKJU+xdrnA5YhVGf7b5A6rx90zMnUtxnthvq5Bh/CP+oi7jsrH6e7DVi ejLL09mXYfZ9/uoPy1bLst9WtIrzU515EyhzKI+4i+U/AUuX1It2AuMg87+MMb39 rEZ82LhrmJ0s4luaI5nfEZ6Xr3ToD/gzYe0sFCRMLgpDbVVNlgdhfmGW2XQMxCVA 2D2y6BmKYkzyzw== X-ME-Sender: X-Sasl-enc: xyRSohW9m4K8jwlyaWk9BIQNaCnG/XDte1ItvLMn4nnU 1497906249 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B75A0248E7; Mon, 19 Jun 2017 17:04:09 -0400 (EDT) From: Thomas Monjalon To: Pawel Wodkowski Cc: dev@dpdk.org Date: Mon, 19 Jun 2017 23:04:08 +0200 Message-ID: <2829321.iV2IKkVC0J@xps> In-Reply-To: <1495624659-226807-1-git-send-email-pawelx.wodkowski@intel.com> References: <1495547976-96270-1-git-send-email-pawelx.wodkowski@intel.com> <1495624659-226807-1-git-send-email-pawelx.wodkowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: allow to map other memory regions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 21:04:10 -0000 Hi, Some comments below 24/05/2017 13:17, Pawel Wodkowski: > Currently it is not possible to use memory that is not owned by DPDK to > perform DMA. This scenarion might be used in vhost applications (like > SPDK) where guest send its own memory table. To fill this gap provide > API to allow registering arbitrary address in VFIO container. > > Signed-off-by: Pawel Wodkowski > --- > lib/librte_eal/linuxapp/eal/Makefile | 3 + > lib/librte_eal/linuxapp/eal/eal_vfio.c | 142 +++++++++++++++++++++--- > lib/librte_eal/linuxapp/eal/eal_vfio.h | 10 ++ > lib/librte_eal/linuxapp/eal/include/rte_iommu.h | 78 +++++++++++++ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 ++ > 5 files changed, 224 insertions(+), 17 deletions(-) > create mode 100644 lib/librte_eal/linuxapp/eal/include/rte_iommu.h VFIO is not referenced in the doxygen of these functions. Could we use this API for something else than VFIO? Any API should be declared in common directory, even if it is not implemented for FreeBSD (returning -ENOTSUP).