Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2017-03-31 14:31, Aaron Conole:
> It's likely that this function isn't used anywhere, but since it was part of
> the public API, mark the function for deprecation for at least one release.
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
[...]
> --- a/lib/librte_eal/common/arch/x86/rte_spinlock.c
> +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c
> @@ -33,6 +33,7 @@
>  
>  #include <stdint.h>
>  
> +#include "rte_common.h"
>  #include "rte_cpuflags.h"

This include should be added in rte_cpuflags.h.
There are other C files which could need rte_common.h,
example: test/test/test_cpuflags.c

[...]
> --- a/lib/librte_eal/common/include/generic/rte_cpuflags.h
> +++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h
> @@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
>   * This function checks that the currently used CPU supports the CPU features
>   * that were specified at compile time. It is called automatically within the
>   * EAL, so does not need to be used by applications.
> + * This version is replaced by rte_cpu_is_supported
>   */
>  void
> -rte_cpu_check_supported(void);
> +rte_cpu_check_supported(void) __rte_deprecated;

The deprecated flag must be moved before the function declaration.
Otherwise clangs throws an error.

[...]
> +DPDK_17.05 {
> +	global;
> +
> +	rte_cpu_is_supported;
> +
> +} DPDK_17.02;

Should not it be a separate patch?