From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com
 [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id A88A8326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 15:26:50 +0200 (CEST)
Received: by mail-wr0-f176.google.com with SMTP id w43so214348157wrb.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 06:26:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=K9ldbv0rd+t6ga4fEKPnPNUxYRe2M0bvBKzcNquq/+g=;
 b=d2XkgciWpmZnMNJNRsJ9mKo9icZUkcmWTwr7rQ9zsLNjlBMo5gT/1/X/2lBU3kawc1
 KoZpRj4971JPTvZ/BP5qlqLZCDbeeTFjmeRliHfJdeEm6Y+PGOj0eOs7THvlm4Il8ggy
 KmfTHSEo7cMGgkkaB/p7jtH+8Zm9a0VeHJdBrsdRmj/oaloIoPu/dj3vomP99APPdrmL
 F0SKGvqI85zKZp3qay9Bf4mg9sZB4yRxsaGoxQ45xUly7BwnRxzrxX4QfS08Q2w75hNa
 XGPYAj5C8s5fDWbX3m7Udy2Bf7xJM3kuD1apNBTgJLYA6BuPHFTzZF0O7+0jvYiDxJE0
 ZawA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=K9ldbv0rd+t6ga4fEKPnPNUxYRe2M0bvBKzcNquq/+g=;
 b=WmPZGDc+3ofdzL/LsaKmIgAonmTOWqsF6y6IwmXcwwOY4OCuxU+Y6iQfmeY1ooPPVQ
 G1M8h3BwthcEfuUL2gRyXdKBwmAXQiq6PFxeXRLMgDvLxqJ7bNxip40e3/+FhTqdDqys
 3MCAR2oO2shGABVxixPFEweEcFOIU3cW/52wQFUhuNdPq0ER6aW8uKQu6XMOp5h6z/5j
 G9fEjJcGP7mVKCnbWAqoVObwuaEAL1pgjRqYn9G69fLuOADCvCq5zzRtCeAbg6ZcvN0m
 KA1D/++jfdRIdrU7yUAo5OMrlY/nfJAEsJSNASHwKpjq4+thWY7yOjqtVMhZP7VTU2jY
 JV0g==
X-Gm-Message-State: AFeK/H3sXHujRpJ8wmC+DBZwoDS8Kll9hLevt1vs+JPY8MzacBWSn1nQdqn5w+XmioYe+V8m
X-Received: by 10.28.159.73 with SMTP id i70mr15127210wme.78.1491312409557;
 Tue, 04 Apr 2017 06:26:49 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id l90sm18500393wmi.25.2017.04.04.06.26.48
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 04 Apr 2017 06:26:48 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org
Date: Tue, 04 Apr 2017 15:26:47 +0200
Message-ID: <2833575.ok4SoAkeVM@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20170331183122.22961-1-aconole@redhat.com>
References: <20170331183122.22961-1-aconole@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Apr 2017 13:26:50 -0000

2017-03-31 14:31, Aaron Conole:
> It's likely that this function isn't used anywhere, but since it was part of
> the public API, mark the function for deprecation for at least one release.
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
[...]
> --- a/lib/librte_eal/common/arch/x86/rte_spinlock.c
> +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c
> @@ -33,6 +33,7 @@
>  
>  #include <stdint.h>
>  
> +#include "rte_common.h"
>  #include "rte_cpuflags.h"

This include should be added in rte_cpuflags.h.
There are other C files which could need rte_common.h,
example: test/test/test_cpuflags.c

[...]
> --- a/lib/librte_eal/common/include/generic/rte_cpuflags.h
> +++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h
> @@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
>   * This function checks that the currently used CPU supports the CPU features
>   * that were specified at compile time. It is called automatically within the
>   * EAL, so does not need to be used by applications.
> + * This version is replaced by rte_cpu_is_supported
>   */
>  void
> -rte_cpu_check_supported(void);
> +rte_cpu_check_supported(void) __rte_deprecated;

The deprecated flag must be moved before the function declaration.
Otherwise clangs throws an error.

[...]
> +DPDK_17.05 {
> +	global;
> +
> +	rte_cpu_is_supported;
> +
> +} DPDK_17.02;

Should not it be a separate patch?