From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2584BA00E6 for ; Sat, 10 Aug 2019 22:29:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A94E231E; Sat, 10 Aug 2019 22:29:56 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DAB14137C for ; Sat, 10 Aug 2019 22:29:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 398C421B6A; Sat, 10 Aug 2019 16:29:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 10 Aug 2019 16:29:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6Samy2GTQ9KQIl4t2V6Y60PRN15vdstsZmJg8gH8joE=; b=XT1aldFNjdHw IenugdoSsiA9gHTBqQa4PFBrspG7m3lTr2aBM/u20pyb1pCcz/m0cPN/YqGhOta8 phmBBcUBs8q61hP6s8ToRVmUvwc3H6OrRZ6/iWw0x8Mons6ptikiDQFlEmIXQxl/ lOtlNAxErigBJ2KOsvq1ERDsHhY2ahc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6Samy2GTQ9KQIl4t2V6Y60PRN15vdstsZmJg8gH8j oE=; b=qPpDNxPRqhMHBMoeudmM/B9Ca7hR/aBBHNcxEvn1C+CxMZaQus0gKUbsl DuFWgIqhdtySw7A3BaIeeMln9PUPRH/3pl78ENqwOeFk0lCRaQOKI+MSbNRcwLB5 GqwmEJdpMHO0CQKMqkNRYvirUyQ6/bWMlnCGllBDfTz2it0qUrEY9xqeysDcKoXi QuU2bg9VdTBjaaVVhHVEN6JSKbGqEGYUSO9kq+AqVXZp4ol/AOuqrxwIm+O47Y2T wPb6hIl+J468m+U6mJ3mqJ8/k9t7QdCd2KXciW0xudh4+VWrzvtFJVmFytyZfYMI hxM/jlfnK3P6lOb8gw2YZvWu5YQhQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduledgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 43B5A8005C; Sat, 10 Aug 2019 16:29:52 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Ferruh Yigit Date: Sat, 10 Aug 2019 22:29:51 +0200 Message-ID: <2836801.4rXPiLtvys@xps> In-Reply-To: <5059724.Axm0xEFYWp@xps> References: <1563890871-26901-1-git-send-email-arybchenko@solarflare.com> <5059724.Axm0xEFYWp@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/08/2019 13:24, Thomas Monjalon: > 23/07/2019 16:22, Ferruh Yigit: > > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > > void return value is bad for get API (like rte_eth_dev_info-get()) > > > since caller does not know if the function does its job or not and > > > output value is filled in. > > > > > > void return value is bad for state changing API (like > > > rte_eth_promiscuous_enable()) since caller should use get API > > > to understand if state is really changed. > > > > > > Signed-off-by: Andrew Rybchenko > > Acked-by: Ferruh Yigit > Acked-by: Thomas Monjalon > Acked-by: Jerin Jacob Applied, thanks