From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF20DA058A; Thu, 2 Apr 2020 10:07:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A18C01BECC; Thu, 2 Apr 2020 10:07:09 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 1C4D91BE96 for ; Thu, 2 Apr 2020 10:07:08 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 3524A58017E; Thu, 2 Apr 2020 04:07:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 02 Apr 2020 04:07:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NCYi+bs2NfOkXiTO40IOhsP80XTlqKfRyVWXaZSL4ZE=; b=P4GA2Z0k2Ye4 ktJ0vNqNKO1gV43deBnyfSJGDrkHdBHkkZHTUyslv4QhZjry3hh7jVYjut7T4BiH +7DmXehAkrO5IWTGwXBcCbAAN67BDYVoftnjMc7jMC/mhejBVO3nYddsVSN6Cmqm d4Pu37FeCfyKwFuKOlf53OesN7ku26o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NCYi+bs2NfOkXiTO40IOhsP80XTlqKfRyVWXaZSL4 ZE=; b=SseCnZ/zCr64b5Z1JZffvzuSixJaaWz3mTke/x7pIynutME9FfxmdIBLs ZUv/UsGIIPGLSwAEfxs0Nyggp4CoFfVek6QODrdJW96Ml0YMxTZmt/duLeRb07H1 njDiPWYP5cRFKtEQChWX92n1iwsk5usjF8drpTMEPJA/g6OsPic+Som14LP+xPCt 07FGAaKP1Iol2iDJmQTWwcVwlkqIvXgsdPKA9ZzHtntqD/uJmsD8Gj+W43jgUInu TPznOFddJdIusan/JOchRbyu3yFmA2UMivR/N1MMLPao2878kM1MiKMjh1X5pLCZ tuwu5Uw7Yj0BpmuHegw38zkSoO7IQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdegucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrih hnpehhuhgrrhhmrdgtohhmpdguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdef rddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B87403280059; Thu, 2 Apr 2020 04:07:04 -0400 (EDT) From: Thomas Monjalon To: Joyce Kong , Gavin Hu Cc: "stephen@networkplumber.org" , "david.marchand@redhat.com" , "mb@smartsharesystems.com" , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "ravi1.kumar@amd.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , Honnappa Nagarahalli , Phil Yang , nd , "dev@dpdk.org" Date: Thu, 02 Apr 2020 10:07:03 +0200 Message-ID: <2838900.VqyquhjGfd@xps> In-Reply-To: References: <20200309095410.28983-1-joyce.kong@arm.com> <1989157.0RtB02Ng89@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/04/2020 09:20, Gavin Hu: > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, April 1, 2020 5:45 PM > > To: Joyce Kong ; Gavin Hu > > Cc: stephen@networkplumber.org; david.marchand@redhat.com; > > mb@smartsharesystems.com; jerinj@marvell.com; > > bruce.richardson@intel.com; ravi1.kumar@amd.com; rmody@marvell.com; > > shshaikh@marvell.com; xuanziyang2@huawei.com; > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Honnappa > > Nagarahalli ; Phil Yang > > ; nd ; dev@dpdk.org; nd > > > > Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD > > bit operation APIs > > > > 01/04/2020 10:27, Gavin Hu: > > > Hi Thomas, > > > > > > From: Thomas Monjalon > > > > > > > > Hi, > > > > > > > > 09/03/2020 10:54, Joyce Kong: > > > > > Bitwise operation APIs are defined and used in a lot of PMDs, > > > > > which caused a huge code duplication. > > > > > > > > Statistics of the series: 653 insertions(+), 326 deletions(-) > > > > I would not say it is a huge duplication. > > > We did not include all PMDs, just a few for piloting and seeking opinions. > > > It is a huge duplication when counting all the PMDs. > > > > > > > > > To reduce duplication, > > > > > this patch consolidates them into a common API family. > > > > [...] > > > > > +PMD Bitops > > > > > +M: Joyce Kong > > > > > +F: lib/librte_eal/common/include/rte_pmd_bitops.h > > > > > > > > Why is it called PMD bitops and not simply bitops? > > > > > > The scope of these APIs are decreased to PMD use only, for > > libraries/applications, it is recommended to use C11 directly as there are > > complications of more ordering models involved. > > > > OK, but PMD means nothing, except this is where it is used *now*. > > Please describe and name the API with memory ordering words. > Will remove 'PMD' in v8. > The APIs were already named with a '_relaxed' suffix, for example 'rte_get_bit64_relaxed'. > According to Honnappa, this patch set just address PMD's requirement, and the current PMDs are not using C11, so only '_relaxed' version is offered. > http://inbox.dpdk.org/dev/VE1PR08MB514983C3200859B27F166EBB983F0@VE1PR08MB5149.eurprd08.prod.outlook.com/ So why not calling this component "relaxed bitops"?