* ring name size
@ 2023-09-04 9:30 Thomas Monjalon
2023-09-04 9:33 ` Morten Brørup
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2023-09-04 9:30 UTC (permalink / raw)
To: Honnappa Nagarahalli, Konstantin Ananyev; +Cc: Morten Brørup, dev
Hello,
When creating a ring, we need to know the maximum length of the name.
It seems this value is not documented.
And there is no constant defined.
There is only RTE_MEMZONE_NAMESIZE.
Should we document the maximum length as 31 and add a constant?
#define RTE_RING_NAME_SIZE RTE_MEMZONE_NAMESIZE
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: ring name size
2023-09-04 9:30 ring name size Thomas Monjalon
@ 2023-09-04 9:33 ` Morten Brørup
2023-09-04 13:04 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Morten Brørup @ 2023-09-04 9:33 UTC (permalink / raw)
To: Thomas Monjalon, Honnappa Nagarahalli, Konstantin Ananyev; +Cc: dev
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, 4 September 2023 11.31
>
> Hello,
>
> When creating a ring, we need to know the maximum length of the name.
> It seems this value is not documented.
> And there is no constant defined.
It is defined (with a description) here:
https://elixir.bootlin.com/dpdk/latest/source/lib/ring/rte_ring_core.h#L52
> There is only RTE_MEMZONE_NAMESIZE.
>
> Should we document the maximum length as 31 and add a constant?
> #define RTE_RING_NAME_SIZE RTE_MEMZONE_NAMESIZE
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ring name size
2023-09-04 9:33 ` Morten Brørup
@ 2023-09-04 13:04 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-09-04 13:04 UTC (permalink / raw)
To: Honnappa Nagarahalli, Konstantin Ananyev, Morten Brørup; +Cc: dev
04/09/2023 11:33, Morten Brørup:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Monday, 4 September 2023 11.31
> >
> > Hello,
> >
> > When creating a ring, we need to know the maximum length of the name.
> > It seems this value is not documented.
> > And there is no constant defined.
>
> It is defined (with a description) here:
> https://elixir.bootlin.com/dpdk/latest/source/lib/ring/rte_ring_core.h#L52
Indeed, thank you Morten. I missed it when looking simply at rte_ring.h.
So we are just missing to mention it in the doxygen of the related functions.
> > There is only RTE_MEMZONE_NAMESIZE.
> >
> > Should we document the maximum length as 31 and add a constant?
> > #define RTE_RING_NAME_SIZE RTE_MEMZONE_NAMESIZE
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-04 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-04 9:30 ring name size Thomas Monjalon
2023-09-04 9:33 ` Morten Brørup
2023-09-04 13:04 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).