From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57521A0487 for ; Wed, 3 Jul 2019 16:06:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EDB82BC8; Wed, 3 Jul 2019 16:06:25 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E56B3231E for ; Wed, 3 Jul 2019 16:06:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 82EBC21FE9; Wed, 3 Jul 2019 10:06:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 03 Jul 2019 10:06:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ErNvujfHQB0lLZ7rg56sUNbqo18CQzBqlwHR4fUStQY=; b=OikIJ3TmepZM 8A7ZHp6zRD5aIt1c3umWZWa0Ax7VLE3HElOJ9MpAKp7KCJI5sx4Uc0nZAa9X2BHR ziy2EVRKtBz9+1T+PJejc0MdqziKZNHLWnVcf/XSnS4h3v3+m7B14Zl7GmOVHFR8 FC4ADrhAW8M3EyHpkFE6dgwkVm7RNPk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ErNvujfHQB0lLZ7rg56sUNbqo18CQzBqlwHR4fUSt QY=; b=Et+zMliEl1RvEtOWbNZYLSocVRDraqd3E5v44k7noLeccIOIabH0AlgdF fZHHYH+1vMdeERYZknOB3al9ouhkzIdFQMtBda26ASqTLRu/QkBiWi9/+e4qXFuY 3ax0E3c5MyjcVzzUTZyTZnBdqrvYuy7ut4wnZzuO4QDjrimmgpf25tvDHxJwzt7J p/ZFKGD4TRmw91tylFD1pMtJshaLuXlIqmwQnhfAav5QaiNvpASR1rFsI9h0Xtpq toIhWF40OanIvA3Lhlo5gmBkVQxO5I4ep7QLSluxr2RG1YChi2QR4RXdA7ZIW69P XwfEyDLh/x2NLds1LxmpiZEP5+yVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3200F8005A; Wed, 3 Jul 2019 10:06:19 -0400 (EDT) From: Thomas Monjalon To: Xiaoyu Min , Adrien Mazarguil Cc: dev@dpdk.org, orika@mellanox.com, John McNamara , Marko Kovacevic , Ferruh Yigit , Andrew Rybchenko Date: Wed, 03 Jul 2019 16:06:16 +0200 Message-ID: <2841769.YOq82iQ06o@xps> In-Reply-To: References: <20190624154018.128379-1-jackmin@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/07/2019 11:45, Xiaoyu Min: > + /** > + * Matches a GRE optional key field. > + * > + * The value should a big-endian 32bit integer. > + */ > + RTE_FLOW_ITEM_TYPE_GRE_KEY, We probably want to use the same format as in Dekel's patch for doxygen documentation of the action value: /** * Increase sequence number in the outermost TCP header. * * Action configuration specifies the value to increase * TCP sequence number as a big-endian 32 bit integer. * * @p conf type: * @code rte_be32_t * @endcode * * Using this action on non-matching traffic will result in * undefined behavior. */ RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ,