From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAFA0A034F; Fri, 26 Feb 2021 10:40:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A6FA407FF; Fri, 26 Feb 2021 10:40:40 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 59FBC40692; Fri, 26 Feb 2021 10:40:38 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id E8D71580570; Fri, 26 Feb 2021 04:40:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 26 Feb 2021 04:40:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ZbQjYvEAS1XXafFlnmXqdE8rkkEyBvezkey+Xus1rVs=; b=ZkVTOfyg+uoKH6+Y 2CTP9SuFmaP1rfMtnrtpcSJqF6pn2CezH8AHyUUcUQ36zJZ6CiCjSklwsBS4rGxx jgVKWWA/hwSiqRyoDwhrjemYn9DtN8PTOQPGLINjw3yY+MosAXHpHrCOKajJYc4b lfqAldhYtBbaC3FElOp02sbPGkpR0VNA97ygjySMUVB/UUB5LecsHaQTw2JJt6AP 3GMODvzG30PlQaeXNlO1XGjP6dOU+STh2Bg++d18UF99UjKZI8SYruj3xfdDFJED Ua0VYwBwbf+1C9uQDxC03UDSOgMTTnRD0P/5/3PXtMG46URnk3aVHsuENLqDPBAN nk6lVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZbQjYvEAS1XXafFlnmXqdE8rkkEyBvezkey+Xus1r Vs=; b=BSc6LoXyZufhXYrnxlD3fRW2hpvV8M4yUHcbJqzcUhvpfKqZVL/x7Hr0p W//aRcFA4A4XQ0PCTvDOvUGG0kjPSU0XOybqnJ5i30u6KZ+NkHyspj7u5nNVc3iz VknpiFRDdLqVuoXaPaRYolYYzZNhZctyEJEdSp6BbH8HoJq7J+qJBC/Fv6GJD2AX SJdRjcdCrv7c5ZsjU1Y08HBTrEK5xmdpPrVR1MeZ1luyBzQgXquh/wi7SPDGji4d Sa1irsZHStRBGxAoJbL61FSnzzd5b69OMBXWlr9PRQ5UWwq0AXs+3F57IdVlED8N Z97JPbATxWyinCNZlPfspcCH0FHAg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrledugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3AD3E108005F; Fri, 26 Feb 2021 04:40:34 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ncopa@alpinelinux.org, stable@dpdk.org, Hemant Agrawal , Sachin Saxena , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Cristian Dumitrescu , John McNamara , Maxime Coquelin , Chenbo Xia , Anatoly Burakov , Konstantin Ananyev , Marcin Smoczynski Date: Fri, 26 Feb 2021 10:40:32 +0100 Message-ID: <2843306.ICY3tYd9bS@thomas> In-Reply-To: <20210226090803.GA1308@bricha3-MOBL.ger.corp.intel.com> References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20210225182250.1149592-5-thomas@monjalon.net> <20210226090803.GA1308@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/02/2021 10:08, Bruce Richardson: > On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > > There was an intent to define _GNU_SOURCE globally, > > but it was not set in pkg-config for external applications. > > > Is this something that we really want to do, to force all external apps to > use _GNU_SOURCE when compiling? Do some of our header files rely on > definitions only available with _GNU_SOURCE? If so, we should probably look > to remove that dependency rather than mandating the define. >From patch 5: In musl libc, cpu_set_t is defined only if _GNU_SOURCE is defined. If we avoid mandating _GNU_SOURCE, we must #ifdef functions relying on rte_cpuset_t in the headers: - rte_lcore_cpuset - rte_thread_set_affinity - rte_thread_get_affinity - rte_telemetry_init (internal) Or a different trick in linux/include/rte_os.h could be: typedef void rte_cpuset_t; so it allows including files, but not using above functions of course.