From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AAB6A04DC; Mon, 19 Oct 2020 16:59:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1DA0E30C; Mon, 19 Oct 2020 16:59:10 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B64A7E2FC for ; Mon, 19 Oct 2020 16:59:09 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4E4D35C01DC; Mon, 19 Oct 2020 10:59:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 10:59:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= /AAc4CFfomWY2F4GaaCFNXwxOEQMz8+kYZCXW6/WLME=; b=LebBVr2KNH9DfbES LzkOAs1LmA7oKvaKqzjXVjTcrkY7Pxj+jSHiN19zfa16fDYrotK5rflQamt6Agur KOOVfWJwtrvr/P7Tv99xZV41JrdED0m6Glk+xCfUPCoFQ8uaOrgB2hFS9GGW41CR Lm3THJ0eE4Ens+R5lvamQ+uBbUHUnU/BMPPATbbVadBb9bt84ZefHsb9QZ4qc304 6A9nnVp3i/tG3pGfAznZtIGSgjbQickaDmY85buy7XHGvzftCUKGkqFdRdttTgL8 RudZg6d9w16Rx65n86FkHypVDksreqxYx5t672Hb4HdYbixJ5z90nhUB2WewovK6 8qa6bQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/AAc4CFfomWY2F4GaaCFNXwxOEQMz8+kYZCXW6/WL ME=; b=BC4UFnpoGohRsol7uZQi2t/+qOrg35albE1o6cuE3nUjTC2A7PIQ/rXqv vEpor2Ptil9IU7AdANczWM1J0CE8hl/sAA+MBpqo5y9pm4x5gdH+eufhELpjm3NR Pcop2vEycdq2wImgKzGKbi3tt1dygyx8B0ulvzcEc8pMRpnrthz1rj1RyO6a8UiW +MYDMqakWcGwL/xAfV8sTrhKP1ZHXIpf9JN3MXxDtqIUK7wQZEr4EAuhR5u/pLBX 05qbfVX7hKpZhyltY1leRg06GASQzHeOQ+1RnU7NH655r7gDOexSvlnBDZc/b899 E7jhZjhJREenwjjtolVgKtvYK8Udw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E009328006B; Mon, 19 Oct 2020 10:59:07 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org, Kevin Laatz Date: Mon, 19 Oct 2020 16:59:06 +0200 Message-ID: <2843596.sukAyEABvh@thomas> In-Reply-To: <7d320cfb-a211-69cd-dbff-68fe8b7f7ad0@intel.com> References: <20201013155648.3471-1-ciara.power@intel.com> <7d320cfb-a211-69cd-dbff-68fe8b7f7ad0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/telemetry: fix socket resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/10/2020 19:02, Kevin Laatz: > On 13/10/2020 16:56, Ciara Power wrote: > > If an error occurred when reading from the socket, the function > > returned without closing the socket. This is now fixed to avoid the > > resource leak of the sock variable going out of scope. > > > > Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON") > > Coverity issue: 363043 > > > > Signed-off-by: Ciara Power > > Acked-by: Kevin Laatz Applied, thanks