From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD33BA00C3; Mon, 12 Sep 2022 12:09:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FB3640156; Mon, 12 Sep 2022 12:09:44 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 14E1D400D4; Mon, 12 Sep 2022 12:09:43 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 561223200406; Mon, 12 Sep 2022 06:09:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 12 Sep 2022 06:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1662977377; x= 1663063777; bh=51Ou70gO3cZe9jXbs7Drbu+lc/jEvNPGypvOfKOeSTc=; b=J khQnXiAA7LURYXFPtwGL9TReTbptlTrBVhvUzXzINZhOEtumeH/e9nhz76aNX5zE +Dn8FwS7IxvaXHUyUoHZ3e1jFSzp2pkpMT897aaY3i9d6Y6XmKMFHDMJSEAqq4Z7 Zzu7vGpcD/aq+5QgSwMObYld/GFzcKFFE/o9VEwDrV2UE1ZFot7YtAWBbVX63xCa WKziFSnvVhSGv0hs65c3uGUvGL4hqdZ41VWoLd6h3X6IVGyGmEVglRwqJ4meJH7O 3x145jbzX3g2tgk8iAocLkUZqk8IYL3OECm901m4jsX0gMl6XkLWS6ozi5V/wgab uH54w0bOHZYyuV6ZF/cBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1662977377; x= 1663063777; bh=51Ou70gO3cZe9jXbs7Drbu+lc/jEvNPGypvOfKOeSTc=; b=V mjVW9MmHW0ALoEcQKJMV9KMi2puB4AICaEsF9x5Q/iKs5EEafU3GRbWWn6dMi1Ml 7GinxXx5pYtRBpCSgJ9f01MZe1UVPJAMQHfx6UmB449RXoicEW+WhvMfs/IgHHfe LP0nlZLWpsn1xnOaXMI51eFixQO0R59ijT6zcs1JulQ03BoPZTLcBxj7/hZ56qcu 8WpgK6eAyBKVLIc+MKROCNqlcvfwLjgVBKzv0DKaue2qR0YJOoX7gow3f46w5eEd e9QwSNaqlnOESLURr5KOiOWAf4n2xHe5e6DTMJljeLKom39SzTDAduEP6FyqmRAU gpK1x4jaJOgZW/suBHidw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduvddgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Sep 2022 06:09:35 -0400 (EDT) From: Thomas Monjalon To: Ilya Maximets Cc: dev@dpdk.org, stable@dpdk.org, Ajit Khaparde , Rahul Lakkireddy , Hemant Agrawal , Haiyue Wang , John Daley , Guoyang Zhou , "Min Hu (Connor)" , Beilei Xing , Jingjing Wu , Qi Zhang , Rosen Xu , Matan Azrad , Viacheslav Ovsiienko , Liron Himi , Jiawen Wu , Ori Kam Subject: Re: [PATCH] doc: fix support table for ETH and VLAN flow items Date: Mon, 12 Sep 2022 12:09:33 +0200 Message-ID: <2843961.e9J7NaK4W3@thomas> In-Reply-To: <20220316120157.390311-1-i.maximets@ovn.org> References: <20220316120157.390311-1-i.maximets@ovn.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/03/2022 13:01, Ilya Maximets: > 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk. > Other drivers doesn't support it. Most of them (like i40e) just > ignore it silently. Some drivers (like mlx4) never had a full > support of the eth item even before introduction of 'has_vlan' > (mlx4 allows to match on the destination MAC only). > > Same for the 'has_more_vlan' flag of the vlan item. > > Changing the support level to 'partial' for all such drivers. > This doesn't solve the issue, but at least marks the problematic > drivers. You changed "eth" and "vlan" from "Y" to "P". The field "has_vlan" is part of "rte_flow_item_eth", and "has_more_vlan" is part of "rte_flow_item_vlan", so I agree we need to change both items to "partial support". It looks to be a good change, just needs to more explicit, adding this kind of explanation about the fields. We missed this patch in 22.07, let's have some progress quickly. > Some details are available in: > https://bugs.dpdk.org/show_bug.cgi?id=958 About rte_flow_item_eth.{src,dst}, I don't find a deprecation notice about it in the history of the file doc/guides/rel_notes/deprecation.rst This is what we have in the code: union { struct { /* * These fields are retained for compatibility. * Please switch to the new header field below. */ struct rte_ether_addr dst; /**< Destination MAC. */ struct rte_ether_addr src; /**< Source MAC. */ rte_be16_t type; /**< EtherType or TPID. */ }; struct rte_ether_hdr hdr; }; Do you think we should remove the old fields now? > Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items") > Cc: stable@dpdk.org > > Signed-off-by: Ilya Maximets