From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4ECBA0350; Mon, 11 May 2020 16:45:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 042661C133; Mon, 11 May 2020 16:45:16 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 38BC81C126 for ; Mon, 11 May 2020 16:45:13 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3C9094DD; Mon, 11 May 2020 10:45:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 11 May 2020 10:45:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= piDJ6ObrJr3SFbBcPK7GVSGTj4Mszie2Vo1iRifPUpA=; b=XE0/pTLx9b4tsNkI dyp3b2LuSAcpdBcCO2v2la6FE9azYaAyLr19DDo+pXYM+P0JoS7wpwbOrzrQ7+mP 1Ib+b3vkvuLvUxsm3FYbel6fjAKmjZGc0BCgEFULW8xXkhggCsfkQToKwrnqihnC hEbA/F+rzgs9Hhhj7lT9wq4mQpkgHTVY2+gTQDhtAfYs/21znpOuqkf1JF37444W mnEcB8APF24iTXUCw5NgrQdLBJdwU/QV5j50rnrm8eNPb1Ili5PY3ap4m6pRHnaR l6ZfVsR8rxsHsDT5lX236gtsrxNRbF4p4AvoVKpVKUMbT10EYSfhSFAk5TTc5oyy hl3IdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=piDJ6ObrJr3SFbBcPK7GVSGTj4Mszie2Vo1iRifPU pA=; b=x7NnxAf6bnpqImNUNpZhseDE/JhbpKPQy+HtOzcki4gBMjB07eHQX+UT0 ziw/lRA4g8RcdTOy/3RuvAyWLhk9uGjgiCrkPcGaD+fIfRtQu+Uql9Ig36mjGILG egxFzLfB4SU+ocpiJl/l3cLIgV/v8HZRH7PJ+lVDYcFRdNLytJLvbVeAFczpzvCO ywnGVlD/1/WGvgu2UDlcxT9mef0Ixn4Iox8sjlaD2Hg56ZAhVXlu0n+7gUs5jAPy z2RyQF1mgPGiRkL4iJlrh4KxtmsOrdPzqScWusmS8j2Ro/pYxd+Yrg6f55wftwmt /wuF9hRoraXYB52ySg/MqvqEpa+Jw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9DB26328005A; Mon, 11 May 2020 10:45:09 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: jerinj@marvell.com, Nithin Dabilpuram , Anoob Joseph , Ray Kinsella , Neil Horman , dev@dpdk.org, david.marchand@redhat.com Date: Mon, 11 May 2020 16:45:07 +0200 Message-ID: <2844085.xgJ6IN8ObU@thomas> In-Reply-To: <20200511100059.5035-1-pbhagavatula@marvell.com> References: <20200511100059.5035-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] common/octeontx2: move internal symbols to INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/05/2020 12:00, pbhagavatula@marvell.com: > From: Pavan Nikhilesh > > Move the internal symbols to INTERNAL sections so that any > change in them is not reported as ABI breakage. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/common/octeontx2/otx2_common.h | 8 ++++++++ > drivers/common/octeontx2/otx2_dev.h | 3 +++ > drivers/common/octeontx2/otx2_irq.h | 3 +++ > drivers/common/octeontx2/otx2_mbox.h | 6 ++++++ > drivers/common/octeontx2/otx2_sec_idev.h | 6 ++++++ > .../octeontx2/rte_common_octeontx2_version.map | 16 +++------------- > 6 files changed, 29 insertions(+), 13 deletions(-) You probably need to add an exception in libabigail.ignore file for symbols moved from stable to internal. > --- a/drivers/common/octeontx2/rte_common_octeontx2_version.map > +++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map > @@ -1,4 +1,4 @@ > -DPDK_20.0 { > +INTERNAL { > global: > > otx2_dev_active_vfs; > @@ -30,23 +30,13 @@ DPDK_20.0 { > otx2_sso_pf_func_get; > otx2_sso_pf_func_set; > otx2_unregister_irq; > - > - local: *; > -}; > - > -DPDK_21 { > - global: > - > otx2_eth_dev_is_sec_capable; > otx2_sec_idev_cfg_init; > otx2_sec_idev_tx_cpt_qp_add; > otx2_sec_idev_tx_cpt_qp_remove; > otx2_sec_idev_tx_cpt_qp_get; > otx2_sec_idev_tx_cpt_qp_put; > -} DPDK_20.0; > - > -EXPERIMENTAL { > - global: > - > otx2_logtype_ep; > + > + local: *; > }; I think you should sort symbols in alphabetical way.