From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05E8645561; Wed, 3 Jul 2024 15:16:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82007402AD; Wed, 3 Jul 2024 15:16:51 +0200 (CEST) Received: from fhigh4-smtp.messagingengine.com (fhigh4-smtp.messagingengine.com [103.168.172.155]) by mails.dpdk.org (Postfix) with ESMTP id 2D6CD4029E for ; Wed, 3 Jul 2024 15:16:50 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A1F211140214; Wed, 3 Jul 2024 09:16:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 03 Jul 2024 09:16:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1720012609; x=1720099009; bh=doURq5VZnAtJPr+0guJ3FzeBYwOCzSGtoyAo9Vqf0WU=; b= DVQaHUCaiMUmTI6s+RARyTqR6cyK/b/ZAj56cueUBg1kfatmLgpgwp6f7SiQpkY1 V30iOhR3u2G4yA9E+2H0O6qYIPWOTI6HGS82+NkR0PQxd3FnLsyZ24ca6xGNfpwE PXROpRuEseQFuo+k+LeKBo0sCMZFsw7FOWeyoP8g6nVBaToriI3Zvi5T4GWJrQM+ tflJMV1XOtbKqtb+cOX/U3tNUHFDSXyIW/pLDRVNoPX9cMlVdcv2km7UMpqp/0ss Xdua1T7I4ytwIJ6jey1hIz+iwT7sP2hsc+Ufy9RTnPR+xCdF5IJMH4D3mOPB2+Xi sxpU8i9+Esq9w0ZVtQcg/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720012609; x= 1720099009; bh=doURq5VZnAtJPr+0guJ3FzeBYwOCzSGtoyAo9Vqf0WU=; b=M xynH0x3Q2YjxZV0idmqAAuC3H1k+gpjKbkex1xZj56UgUQ0d67yR1REe1UT7V5Jg lrv3CK+g6MwJ7tQNwrVqJYUQinAKlvqhPS142hI1OLzwPahfofSF12+Axq3LOGPF 0VX8o8nQ5u0tPRcvlxJ6x0g9EeLrI9qsAAKcbWlAleoOoZfuFPD8133gtY1rPBEu HsVdSgTsN9I2lozCbeV+Mx/7gClDinTrrSmeJZv8rsws6zHTqzPizabu6MuBfngU qLaEEWxjtH6SijtzSI798z+6fua09Sdaw1QxCBk2iZQCxya8a4iq92wlgjhtgkTh j7Ipo06nDPymyo+H73fCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Jul 2024 09:16:47 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , Andrew Rybchenko , David Marchand , probb@iol.unh.edu Subject: Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin Date: Wed, 03 Jul 2024 15:16:46 +0200 Message-ID: <2845507.vgeOAicOrc@thomas> In-Reply-To: References: <1710970416-27841-1-git-send-email-roretzla@linux.microsoft.com> <4023574.2iPT33SAM4@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/06/2024 16:32, David Marchand: > On Wed, May 29, 2024 at 4:51=E2=80=AFPM Thomas Monjalon wrote: > > > > 20/03/2024 22:33, Tyler Retzlaff: > > > Use newly introduced __rte_constant(e) macro instead of directly using > > > __builtin_constant_p() allowing mempool to be built by MSVC. > > > > Does it mean we should enable mempool build? > > If yes, please send a v2. >=20 > I guess now it is possible, as I merged some other patches on mempool > from Stephen that were for MSVC. > Tyler, can you send a v2 so it passes through the CI? I tried a retest last week and there is this failure on Ubuntu 24.04 that I don't manage to reproduce locally: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: argumen= t 2 null where non-null expected [-Werror=3Dnonnull] 29 | return __builtin___memcpy_chk (__dest, __src, __len, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 30 | __glibc_objsize0 (__dest)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in a cal= l to built-in function '__builtin___memcpy_chk' In function 'memcpy', inlined from 'pcapng_add_option' at ../lib/pcapng/rte_pcapng.c:131:2, inlined from 'rte_pcapng_write_stats' at ../lib/pcapng/rte_pcapng.c:371:9: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: argumen= t 2 null where non-null expected [-Werror=3Dnonnull] 29 | return __builtin___memcpy_chk (__dest, __src, __len, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 30 | __glibc_objsize0 (__dest)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in a cal= l to built-in function '__builtin___memcpy_chk'