From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 7DF1EDE0 for ; Thu, 4 Feb 2016 09:49:08 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l66so15675053wml.0 for ; Thu, 04 Feb 2016 00:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=03PuvP3FCJwRhpRldPyRuBQDhlxK15YL06y6CGmSC3g=; b=R19NkYeYhD03havqHfvac6MPTFxkJ6JJGIcrtT49X1U7dqCXSdgwpz6BnsRxOeUUg4 UwrujTzHdzA7zRD4ViwIp2UOVk0DO/Zhiou0n8nJUGQhZ7aqhbjFD2naZtBQKECaSkt0 VeGyfmAMW04Tp9rc73HfEhGTOcp73gCOApYlZURX4zh3SFx3uyWh96AthkfSFB4ifACl Av/xGqQbDP1Yq4HRf4SuQqi3CBVWJR66g+8WsLy02GxqitmhmvsSeSirsAlfb+O9Mwoy +rU1txPTxDXUx8gCLe4bM7dkBsRNtp+SpsAFLTcO+xAhJe/n5O0SyZGekBSPTrnZzi0z eZUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=03PuvP3FCJwRhpRldPyRuBQDhlxK15YL06y6CGmSC3g=; b=Pm1n/SZFl2B3gsXxBU/wchrRkuaXTUsXpPw4lhp48pqkeUIpAP7zDhJcOpcTuNOLiK inDOHxEat2Tnx8/GqYlr3ZIvw4pxMZTwOfmvgL0VQFCJG/oS0ue753F9zFHnwawzBteq sUKym9F5TojrI409kwiA10VL2w7cj1lje8R3CZovRdiMHKzq0cUDOYTEE5cWBRAtdV8r LMOhPDbnJXvJD9b/DjORFZYQvy5MNGJdx3sjHp9581p+tKAMxfcHzYCuhIBHZd9edIom VpUzs6+xg4pxuCtSiD8JztetB3Uzsj4kTlL8kVnWAPSw2QUINt/qzrqEj8IiRm0B9hF1 CkTA== X-Gm-Message-State: AG10YOTHjh+KQrVheOe1DDFk3Q8qH2R+uvym7Kl3tCZnmGZJUF1P1A0ww1RtqqJt2RSgaX86 X-Received: by 10.194.104.6 with SMTP id ga6mr6755256wjb.17.1454575748304; Thu, 04 Feb 2016 00:49:08 -0800 (PST) Received: from xps13.localnet (136.21.90.92.rev.sfr.net. [92.90.21.136]) by smtp.gmail.com with ESMTPSA id w66sm11666404wmd.2.2016.02.04.00.49.07 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Feb 2016 00:49:07 -0800 (PST) From: Thomas Monjalon To: "Wang, Zhihong" Date: Thu, 04 Feb 2016 09:47:54 +0100 Message-ID: <2848756.Pj2zKKyaol@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941033ACABA@SHSMSX103.ccr.corp.intel.com> References: <1454525799-25552-1-git-send-email-thomas.monjalon@6wind.com> <1454525799-25552-2-git-send-email-thomas.monjalon@6wind.com> <8F6C2BD409508844A0EFC19955BE0941033ACABA@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] eal/x86: fix build with clang for old AVX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 08:49:08 -0000 2016-02-04 03:35, Wang, Zhihong: > > Subject: [PATCH 1/3] eal/x86: fix build with clang for old AVX > > > > When configuring RTE_MACHINE to "default", rte_memcpy implementation > > is the default one (old AVX). > > In this code, clang raises a warning thanks to -Wsometimes-uninitialized: > > > > rte_memcpy.h:838:6: error: > > variable 'srcofs' is used uninitialized whenever 'if' condition is false > > if (dstofss > 0) { > > ^~~~~~~~~~~ > > rte_memcpy.h:849:6: note: uninitialized use occurs here > > if (srcofs == 0) { > > ^~~~~~ > > > > It is fixed by initializing srcofs to 0. > > > > Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512") > > Hi Thomas, > > Thanks for pointing this out! > My last hasty modification on this is not correct. > > The patch below will fix it. All modifications are tested. > Sorry for all the hassle! :'( > > "srcofs" should be calculated based on source address anyway. OK Please send a full patch as usual, thanks.