From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 953662BC9 for ; Fri, 1 Apr 2016 10:25:30 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id p65so13229193wmp.0 for ; Fri, 01 Apr 2016 01:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=fcvZaEolPsFn4eRDDsA481QiFBAQ8OTlwLUDpfDGpSI=; b=M69WA4OhqE/kXsz319cS1uf/X6nXxwPNxJTq9+GgHgPD52CkWbq/NBlNhsi/pc658p qM2YppGP3KZNTebwgbdkb9LXy2jzQyg3PVm4GjujXlw96+qQGbJRGDiEVZ1d+jhBjr2A eOBC6XvjbRe8Ba6R2imxqDyWPr5/RbR3eTJcJWv9JadZ4MhbF/mZlWRXjkFpnZA2vGAh H0eDjLO3rHHte1UkwoXGwN7ED0uNjoY1Wx/MpjRO8GBNHuw0o+bHyITnGMUF8Z1CHmW9 SsIlAkaObSMoGDX3id2zzGrharmqlshdgXaZNWmythC8Eu14JGGRMTNBEqTahTlz9nii rZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=fcvZaEolPsFn4eRDDsA481QiFBAQ8OTlwLUDpfDGpSI=; b=FBboFPAVS5h9JPPQMsbWYcQWFB4f8xT3z1sSOzsKKk75SE68yfdIGfQKvHx2B1FdZK /rFrqWmuKFrnet92Dm6tRODyDbuXtXhSStEwVqukJpCU/iHVKirALocJazv93RjkYewD TdQYruZBAgVyrtwBzLjZbWcjapARVl1QpaESe0QSt0CsTgk1LFLX+a+HZuau3U9/JmCf nbMXHtJLpBc4pJivLRvkHOhJwAiXXPtWcy8QwCGGYcJeo0x/kw5gh70OEpjY3hHENo1j 9cN8VelMr6NtDiGUdjfZXZOxWVuKHtOzZduolbqrbqEPMseZyQeKz09sSQQxY6/Ydnf4 0WUQ== X-Gm-Message-State: AD7BkJISVH5TwLTLPIR+Ei6iYHnTR/+d9Lpo+ph00XrMb7y3F4AnPzmtKW9U3aY2/ljWlgmO X-Received: by 10.28.111.92 with SMTP id k89mr2497894wmc.36.1459499130362; Fri, 01 Apr 2016 01:25:30 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i2sm12889479wje.22.2016.04.01.01.25.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 01 Apr 2016 01:25:29 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Cc: dev@dpdk.org, helin.zhang@intel.com Date: Fri, 01 Apr 2016 10:23:35 +0200 Message-ID: <2849253.L9bo604lkH@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1459474604-2049-1-git-send-email-jingjing.wu@intel.com> References: <1459474604-2049-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] i40evf: fix link info update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 08:25:30 -0000 Hi Jingjing, Please rebase on top of Marc's patches. 2016-04-01 09:36, Jingjing Wu: > +* **i40e: Fixed link info of VF a blank line is missing > + Previously, the VF's link speed kept as 10G and status always was up. It did not > + change even the physical link's status changed. Now this issue is fixed to make > + VF's link info consistent with physical link. [...] > + new_link.link_speed = ETH_LINK_SPEED_100; > + break; > + case I40E_LINK_SPEED_1GB: > + new_link.link_speed = ETH_LINK_SPEED_1000; These speeds have new names after Marc's rework. > + new_link.link_status = vf->link_up ? 1 : 0; Please use new constants for link up and down.