From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 238BE2C16 for ; Thu, 3 Aug 2017 22:06:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7CA792082B; Thu, 3 Aug 2017 16:06:46 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 16:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=xtgnyCnjJvrOssN uTKq+zzJ6uRtD4J/eM9oWxI7Pao8=; b=ePdGYrtZ+6ALacps9hUsSghvX0Ueet5 uRUhJGaE4m5jKkymEjXVxNXp1+N61jHF2F/iqKXezAXI3TIccQxUDPALhluL59gt Etzft5mp8h28Qdl6K9ORf/t5Gc5MCLkEBdywQDvK6UVAVirzpeGO0YSicJgRMNY2 Z9qBFMBlHjHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=xtgnyCnjJvrOssNuTKq+zzJ6uRtD4J/eM9oWxI7Pao8=; b=eXenu1Ia w2LR1IJLVEou95nYrZ1CWT//bV5Kmgv2DPJ3zjmOZ1YL2cW3EeLMECJ5y3+GtKSy dFzyyJEMbxtg4JY5s2H/cjvCOW8measo/pMVatjTPgtjpSMdZnduXUgfp9pW/OUO yMJC3T6SYb9hGS8p/3KFBFVLIPnhYW+gfUkmbG9ShkJbaPvIz6QIkFtq1bM7AKba 6NhX1ZFd2A/QF54aYaS8SHpPhtTxbCududN2syNEWKeK2Pto9H9Ajnd7c8VQ8Str AAkSr8AhsirU1ldQ5MIvKhhyqbV6WqlAdvLkUvs4oSyHsKFHDERQj2beptQ9/r0C Ft7omaHJsdDojQ== X-ME-Sender: X-Sasl-enc: r2OLWqp+alD/C84kSMMefAjhXqQC03FlepBpaZwEtJ+K 1501790805 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id EC76A7FA5D; Thu, 3 Aug 2017 16:06:45 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Thu, 03 Aug 2017 22:06:43 +0200 Message-ID: <2852960.RY6FMqKSor@xps> In-Reply-To: <90dae107bf7e55ec42ae8223d5666a77bd9ddfe7.1501763614.git.gaetan.rivet@6wind.com> References: <90dae107bf7e55ec42ae8223d5666a77bd9ddfe7.1501763614.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix leak in hotplug add on parse error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 20:06:47 -0000 03/08/2017 14:34, Gaetan Rivet: > If rte_eal_devargs_parse fails, the rte_devargs has not yet been inserted > in the global list. When jumping to err_devarg, the removal fails and it > is not properly freed. > > Free the allocated rte_devargs if its removal failed. > > Coverity issue: 158658 > Fixes: 7e8b26650146 ("eal: fix hotplug add / remove") > > Signed-off-by: Gaetan Rivet Applied, thanks