From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, jianfeng.tan@intel.com, roy.fan.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix build issue with GCC 4.7.2
Date: Fri, 27 Apr 2018 11:25:45 +0200 [thread overview]
Message-ID: <2855253.2u4rUxKpDl@xps> (raw)
In-Reply-To: <20180427090438.31506-1-maxime.coquelin@redhat.com>
27/04/2018 11:04, Maxime Coquelin:
> Build error has been reported by Intel build system:
> SUSE12SP3_64 / Linux 3.7.10-1 / GCC 4.7.2
> lib/librte_vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_set_zero_copy’:
> lib/librte_vhost/vhost_crypto.c:1192:2: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
>
> As enums can be either signed or unsigned, this patch removes
> the negative check and cast to unsigned the upper limit check.
>
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied, thanks
prev parent reply other threads:[~2018-04-27 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 9:04 Maxime Coquelin
2018-04-27 9:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2855253.2u4rUxKpDl@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).