From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id C86D19AD6 for ; Wed, 8 Jun 2016 14:22:19 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id n184so179082351wmn.1 for ; Wed, 08 Jun 2016 05:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=CsVFfT30ZHyCGfsoBynYPK5l7T+pQVlzVfO6DhudmDo=; b=oNwYU7mEDoxz/b/ldsCAOTLIQkyH7ofNqrK8ofbI5fOBQbHJt1ZkJFFKt5UDtorr9I FhN7uukMMR8tj58lwyXONR+0DAJpWIslULab4so+POn/VJ8qOC2wZeu+3HvMuCrYfru9 E6QanoRhskqjsA8JZsg+c+oGLbf+1nNM+fYejkESne/DyCm4fCQZXJiUmM5NqpWlRHdV O7mi0dJQiDrlwJ62li1S/tuOx355ZgSYEbpUj0dnIdf35/2cuYJpyx/fb/7qtD8XC8SW 74aeZvXyjFK+jEP8PHyeuiMMscJ077G+HpNzz8XAmVUL3PoLCyCvkG2qau7rFrq6Uspw TMPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=CsVFfT30ZHyCGfsoBynYPK5l7T+pQVlzVfO6DhudmDo=; b=U2/v5RqN9qO9LlhyqH/nWkn1VmreY56TcI6bh37wyL+WtUgv1cPrARxNP+1jGQNrbR DEFb5kApCktPEufvOi70eEHelFRyaAqIjm8FSP3u1qF3bPenQlgBNSbzZrphi2ONEOJ3 hbxAEZpBgtOGqhfqglKpBjcfD5t93ymARLxc2DmR4VigF9lA9foLbsBNuINT+5dDSnS7 kVTY50/2qQYXWTGDZAjAM4RNe2v6+KV8kUVKkHCnVQ34s32q1MSkeCAdBSQREw67ySIA GDWJm+MTGWVFYUPFL8RR8f7bsXaPaC+echxoB/7vkyX7Mq3PxJvOsLhiFCQJ6xGN3lXO 50nA== X-Gm-Message-State: ALyK8tLiD6wFoDLMGhZAys8+iLKaOx42d/zaikocXtrAtGzGB9P+C28cTxP69+pIRhyr7U5j X-Received: by 10.28.20.139 with SMTP id 133mr4521947wmu.35.1465388539411; Wed, 08 Jun 2016 05:22:19 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id s9sm1191479wjh.48.2016.06.08.05.22.18 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2016 05:22:18 -0700 (PDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Wed, 08 Jun 2016 14:22:17 +0200 Message-ID: <2855986.LtnRHLyA0p@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5757FE95.3090403@intel.com> References: <1464605292-4599-1-git-send-email-remy.horton@intel.com> <2437213.nzTWdctYcm@xps13> <5757FE95.3090403@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 01/10] rte: change xstats to use integer ids X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 12:22:20 -0000 2016-06-08 12:16, Remy Horton: > 'noon, > > On 08/06/2016 10:37, Thomas Monjalon wrote: > > 2016-05-30 11:48, Remy Horton: > >> struct rte_eth_xstats { > >> + /* FIXME: Remove name[] once remaining drivers converted */ > >> char name[RTE_ETH_XSTATS_NAME_SIZE]; > > > > What is the plan? This field must be deprecated with an attribute. > > We cannot have 2 different APIs depending of the driver. > > This is where it gets logistically tricky.. > > Since there's an API/ABI breakage notice in place on this, my own > preference would be to have the entire patchset quashed into a single > patch. Problem is that rte/app changes (patches 1 & 7-9) are normally > applied via master whereas driver changes (patches 2-6) go in via > dpdk-next-net - it is not clear to me how patches should be submitted > for this case.. Misunderstanding here. Patches are fine and will be integrated in the main tree because they are not only some drivers changes. I was talking about the old API with name in rte_eth_xstats. I have not seen the patch 9 which removes it. > >> +int rte_eth_xstats_count(uint8_t port_id); > > > > This function is useless because we can have the count with > > rte_eth_xstats_get(p, NULL, 0) > > By the way it would be more consistent to have the same behaviour > > in rte_eth_xstats_names(). > > Feedback I got with earlier patches was that a seperate count function > was preferable to overloading the fetch function using *data==NULL - is > the use of the latter specifically preferred? I prefer the fetch/NULL style to get a count. It also handles nicely the fetch error because of a too small buffer.