From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9EC442C04; Thu, 1 Jun 2023 16:05:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9728640DDC; Thu, 1 Jun 2023 16:05:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 28915406BA for ; Thu, 1 Jun 2023 16:05:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685628323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xFO1A49cqKfci1WBOGBhFkmW8qWCHs8Uy5NQPjrbS28=; b=CE9NAD37vo1shlm9b6JvLTBg7geK4lARpZXBv4bNXvEgI9soSkHZOIzIq3xHXYGEUxHnwC eF7IbfAMQ0hjJhAO3hz3r9D/R4xQXMplPOhONLnqvfKl1qBaL32TQFTCl158lpkcR3wMYA gfPdXNZVeCfpCYymMGvTkhqO2i1+SHQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-383-HdULKIKuMqGJo-uglCbXLw-1; Thu, 01 Jun 2023 10:05:20 -0400 X-MC-Unique: HdULKIKuMqGJo-uglCbXLw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1CE428237C3; Thu, 1 Jun 2023 14:05:19 +0000 (UTC) Received: from [10.39.208.25] (unknown [10.39.208.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69F4C492B0A; Thu, 1 Jun 2023 14:05:17 +0000 (UTC) Message-ID: <2856178d-bd90-0b7e-55d8-cb9381306d71@redhat.com> Date: Thu, 1 Jun 2023 16:05:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 18/28] vhost: add VDUSE device creation and destruction To: David Marchand Cc: dev@dpdk.org, chenbo.xia@intel.com, mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-19-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/26/23 11:11, David Marchand wrote: > On Thu, May 25, 2023 at 6:27 PM Maxime Coquelin > wrote: >> diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c >> new file mode 100644 >> index 0000000000..d67818bfb5 >> --- /dev/null >> +++ b/lib/vhost/vduse.c > > [snip] > >> +#define VDUSE_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ >> + (1ULL << VIRTIO_F_ANY_LAYOUT) | \ >> + (1ULL << VIRTIO_F_VERSION_1) | \ >> + (1ULL << VIRTIO_NET_F_GSO) | \ >> + (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ >> + (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ >> + (1ULL << VIRTIO_NET_F_HOST_UFO) | \ >> + (1ULL << VIRTIO_NET_F_HOST_ECN) | \ >> + (1ULL << VIRTIO_NET_F_CSUM) | \ >> + (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ >> + (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ >> + (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \ >> + (1ULL << VIRTIO_NET_F_GUEST_UFO) | \ >> + (1ULL << VIRTIO_NET_F_GUEST_ECN) | \ >> + (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \ >> + (1ULL << VIRTIO_F_IN_ORDER) | \ >> + (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > > That's a lot of indent/spaces. > > #define VDUSE_NET_SUPPORTED_FEATURES (\ > (1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ > (1ULL << VIRTIO_F_ANY_LAYOUT) | \ > > > Plus, can't we use RTE_BIT64? (this could be a cleanup to do on the > whole vhost library) > > Agree we should move to RTE_BIT64(), I'll do that in another patch for -rc2 if that is fine to you (including the indents/spaces reduction). Maxime