From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 30B421518 for ; Thu, 27 Nov 2014 22:05:05 +0100 (CET) Received: by mail-wi0-f172.google.com with SMTP id n3so16844375wiv.5 for ; Thu, 27 Nov 2014 13:05:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TSSx6lhoZHtLKHw7M33eoQEyOD6I6RrFvdejRi3+LIs=; b=Wc1fw44eKPqUOGNqB0oX9c//19ZZla/VkGhzTW0D0+FSyhYS/OCUqCtHRnk+oYgVPR ouD4xM2th0daxIuzO7H/LerN9BUMwssQ/nDTK+0P7j1kuLjQfYvvgx2V1ntf5uRQO5Bq EINiwEHlFKsq60/Jqw/byGUHGWCaNtUt88WoT8qFAxOV0EMMaOUWHYv+/nRCRonMRN2K fMphWvf1KOPCA0tj97ZhpdYIiO/kB8O35/pK2PRtcH0iQs3ubk/UCOclvKbAyfRwyJiB VUhO8o/P6+TVLaycOsNpm1kgcbuXFE+Y/p9wWnAI5crA8o71wrRb0/zaRZsnj6qcbhRM qAPw== X-Gm-Message-State: ALoCoQnI8k2a5LNnCGGgtLHo9nfeOTiIog0dcby8nYIC0PfJkQtKgCh2NwqV5ll7jPDLZb84557W X-Received: by 10.180.98.170 with SMTP id ej10mr54103391wib.74.1417122304924; Thu, 27 Nov 2014 13:05:04 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a2sm13161301wiy.11.2014.11.27.13.05.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Nov 2014 13:05:03 -0800 (PST) From: Thomas Monjalon To: Yerden Zhumabekov Date: Thu, 27 Nov 2014 22:04:41 +0100 Message-ID: <2858592.pE1d5roQkI@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 0/7] rte_hash_crc reworked to be platform-independent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 21:05:05 -0000 2014-11-20 11:15, Yerden Zhumabekov: > These patches bring a fallback mechanism to ensure that CRC32 hash is calculated regardless of hardware support from CPU (i.e. SSE4.2 intrinsics). > Performance is also improved by slicing data in 8 bytes. > > Patches were tested on machines either with and without SSE4.2 support. > > Software implementation seems to be about 4-5 times slower than SSE4.2-enabled one. Of course, they return identical results. > > Summary of changes: > * added CRC32 software implementation, which is used as a fallback in case SSE4.2 is not available, or if SSE4.2 is intentionally disabled. > * added rte_hash_crc_set_alg() function to control availability of SSE4.2. > * added rte_hash_crc_8byte() function to calculate CRC32 on 8-byte operand. > * reworked rte_hash_crc() function which leverages both versions of CRC32 hash calculation functions with 4 and 8-byte operands. > * removed compile-time checks from test_hash_perf and test_hash. > * setting default algorithm implementation as a constructor while application startup. > * SSE4.2 intrinsics are implemented through inline assembly code. > * added additional run-time check for 64-bit support. So you don't want to use the target attribute as suggested by Konstantin? Why the discussion ended without any acknowledgement? -- Thomas