From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 821EC42E56; Wed, 12 Jul 2023 18:19:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07B3F40A7D; Wed, 12 Jul 2023 18:19:26 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 62544406BA for ; Wed, 12 Jul 2023 18:19:24 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3F8D232004CE; Wed, 12 Jul 2023 12:19:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 12 Jul 2023 12:19:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1689178762; x=1689265162; bh=5rdxUrxO6W3DvJUlRWQsTS3nNZp6u8UqR/r jbvTU0e4=; b=tjJ8zP6VrUkr1oAuWOMbITI1sy46KVktTj5bJ9EfkDHTpnxatGI 5LCmww5aeJ7s7neIK8BIcPkHbll8RDugw+V8iyyVyPPFigB2ps75Za2mdTCAX15b 8+9uoEOM5/gi8dCG6alyLBmrpLSsKPKxjwfE9Tid+WUUfrTkqjZIwkDRdecN1N7Y a7kZWgJJHpqtANqlYVYr6PsIXwQBeefDN1xgSl63U6ULvslfPp8k0nVhjjFIDNHV YcPVZOnuMMAa1Hnpv1YogLl00PoJdHB3XuaXmw0+L9wUZzBCCZiB2qOp/1ZJTnXR u5GVK2naxm6Mf4bf+ArmpOQG1sCciBuO/ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1689178762; x=1689265162; bh=5rdxUrxO6W3DvJUlRWQsTS3nNZp6u8UqR/r jbvTU0e4=; b=aKOoE6QCc5codUkdI8EvAMlGLHNurSJrcKeNowvzBkI8rUigDfI EMHuohspzfY2RV8mAuv4yIdI0fyEw5fSc+h8n7BhyBMoEyXUZAoayy5Vd7gHLmAX tBhC46ZoFDjfpcs9aP1GFrYTIfJ5OBuCzZaclvBcdXR4grhONLwqAt+CzPok06c5 pG+32alDftGK7n9+JNM9kj5bxIlMIpl2PZ51vV+fNGovuN6qBiVaIDeEZXLHX49b TUlLGYdWRUB4R8tM0K/2lFF5LxKTN2udULbiC6Fd3Pfndw3GiNJUl9Xp/NOqt4CK +MfABKmklEPDN7P2yxeCcgtTkfFZio5g0CQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfedvgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jul 2023 12:19:21 -0400 (EDT) From: Thomas Monjalon To: Raslan Darawsheh Cc: dev@dpdk.org Subject: Re: [PATCH] devtools: fix bad substitution Date: Wed, 12 Jul 2023 18:19:19 +0200 Message-ID: <2862366.C4sosBPzcN@thomas> In-Reply-To: <20230711071619.26797-1-rasland@nvidia.com> References: <20230711071619.26797-1-rasland@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/07/2023 09:16, Raslan Darawsheh: > When running check-git-log, it showed a Bad substitution. > > It is fixed by using tr to escape the open parenthesis. > > Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses") > Cc: thomas@monjalon.net > > Suggested-by: Thomas Monjalon > Signed-off-by: Raslan Darawsheh > --- > devtools/check-git-log.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh > index 89544a2cc5..5c869b7683 100755 > --- a/devtools/check-git-log.sh > +++ b/devtools/check-git-log.sh > @@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range | > sed -rn 's,.*: (.*<.*@.*>),\1,p' | > sort -u) > bad=$(for contributor in $names ; do > - contributor=${contributor//(/\\(} > + contributor=$(echo $contributor | tr '(' '\\(') tr was not working here, replaced with sed Applied, thanks.