From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F07A053A; Wed, 5 Aug 2020 11:06:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEA611BFFE; Wed, 5 Aug 2020 11:06:10 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 3126E1BFF5 for ; Wed, 5 Aug 2020 11:06:09 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id A82DE580500; Wed, 5 Aug 2020 05:06:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 05:06:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8VrVgiMqvEGOMgEwlEHOHPPjaTusuAP32IM3+2K9SkA=; b=lK3FjjgU27MiM8IK IOPzYppeOdYBf6bGuZr91ZetLcLVaUt/tyUv9qUopFmpRi39Gw5pilwUeilL3Gim M837J5+4d/dDzrLrnKcLrY8FpYer1gc7BK3ChlE457/Fg1pZSXZLY9YCdrCRWRvQ zMsqL1rU17RDIV21FAD+PmCb2A53IVZu6Rq1c9m8DX7IliLo0VTHPBN7GmF5Ys5d Ble5NEpEnMP2FN1WfMEXZH9xduemK7Mn4am0HfUE/WbciVcTkRDzmwVIk7TJ+YhF UoJfoMlEua0CafBm3QxNfwIJi1Z8U3cDmLh1zV+uCIs8Qx4AZQQK1kYoM2frrbfF IvoHwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=8VrVgiMqvEGOMgEwlEHOHPPjaTusuAP32IM3+2K9S kA=; b=J35PkFvFumAuDtuGIZN8COSe8oRXTacdIMIU1F+gBzhbycc9ubLPs9XbQ 1/QMvfOtWymTsUuLYA0Zcn7a6Wh/KzM22N/IC/OuOIaBKTGF//N47FpQSd/+w0Fr 3MGW0WJBzdqW5RyJKBFYx3aoK6FAPB+20FY9QPGBMBXAJYyWC630HDIxTjQv6P9/ oPsvZ8MAdZtfQFnDI73cWWaTra2iCM1l9TUKlPIWQNkLwNA5P6jujtVh51u7exAG MPB7u8NCyIkM99uWrYE+nqryKm8EKAaA8ZvUTNsFyhvw9NvNrkjnNnZ5FOahGTiD 6uZuhJwkSt6IS72aVGiSX6geAOHCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7DE8730600A6; Wed, 5 Aug 2020 05:06:06 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , kevin.laatz@intel.com, ciara.power@intel.com Cc: Dmitry Kozlyuk , Fady Bader , dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, navasile@linux.microsoft.com Date: Wed, 05 Aug 2020 11:06:04 +0200 Message-ID: <2862680.3ZvUzCBnBg@thomas> In-Reply-To: <20200805083621.GA1709@bricha3-MOBL.ger.corp.intel.com> References: <20200625133038.25180-1-fady@mellanox.com> <14102736.rQ7LXLPuFW@thomas> <20200805083621.GA1709@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/08/2020 10:40, Bruce Richardson: > On Wed, Aug 05, 2020 at 10:27:27AM +0200, Thomas Monjalon wrote: > > 05/08/2020 01:39, Dmitry Kozlyuk: > > > On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote: > > > > Telemetry didn't compile under Windows. > > > > Empty stubs implementation was added for Windows. > > > > > > > > Signed-off-by: Fady Bader > > > > --- > > > > lib/librte_telemetry/rte_telemetry.h | 4 +++ > > > > lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++- > > > > lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- > > > > 3 files changed, 79 insertions(+), 2 deletions(-) > > > > > > You could #ifdef code in librte_ethdev that uses librte_telemetry and not > > > build librte_telemetry at all. This approach is already taken in > > > eal_common_options.c and it avoids spreading #ifdef throughout telemetry code. > > > > The problem is that telemetry can be used anywhere, not only in ethdev. > > I feel it is better to #ifdef telemetry than every telemetry calls. > > > Given that the majority of telemetry has no external dependencies (jansson > is only used for the older compatibility part), and it uses sockets for > communication, is there a reason why it can't just be made to build and > work on windows? The unix domain socket could be converted to a standard > UDP socket on localhost, perhaps. Is there anything unix-specific beyond > that? Yes of course telemetry should build on Windows. But it seems nobody committed yet to work on it. Feel free :)