From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5916E4894F; Thu, 16 Oct 2025 10:43:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2694240B90; Thu, 16 Oct 2025 10:43:03 +0200 (CEST) Received: from fhigh-b2-smtp.messagingengine.com (fhigh-b2-smtp.messagingengine.com [202.12.124.153]) by mails.dpdk.org (Postfix) with ESMTP id B7903402C3 for ; Thu, 16 Oct 2025 10:43:01 +0200 (CEST) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id F116C7A010C; Thu, 16 Oct 2025 04:43:00 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Thu, 16 Oct 2025 04:43:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1760604180; x=1760690580; bh=t1Aqz24SbAI/jyYXuRv4KyvWQ79timAVweQLowJ95Fk=; b= EpCDTbmyk1kOiTckztQXK0pQXzKO9F46WtccIOVxveBHYCTAwTfao5Pw49cVjyJU 5L3KoUdga9uoaQ7rYgNTpy1+0D/d3zYISxh3TsxtqiyTcljjuMtC/AWMSna053XD MG+p8bYnl+EbxZ+zf3qMao0vMA3OpsCfIMAX0Jj74odAUBMVJ7JS4YpRIdc7ZdTL eygWMpcneMnPiHvfcrfBvruDD/9Ekm0roKO0mk9gWUimwqg/vjI+mEzgoBlrau9D ZnZAVzq4WyZ/PXWdZ4wUeOO+txEimcRD9r7j61itkAef1j4dSDlyZ8bR7JaWLvUt MmS712Qpjx2AE30X19bAhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1760604180; x= 1760690580; bh=t1Aqz24SbAI/jyYXuRv4KyvWQ79timAVweQLowJ95Fk=; b=e wb8GN7mGFggXfIkEpjW28lm+7uPMSJn4MSt95siEdZIcI2Q25jCdlMrtw3SRidMN R1HYtO0aJRlgbBfRTa28QhWCXSOH5RDHHJeWU8yIPjCjpEwsrT+BHf+NFUw8Nrk2 dlmAdQIND8cCQ+9RGrRThVHsZN+w8hDV2iMW0BZPgO+XUVcu8GowOtRYivz1uozE YIcpBl2S2csNwOh/W9YV+WMSdrDxHwFBBguUGb00p0hqgCUcAsuv7kSFP4uzzZdC dvt8zIsQF4ZAxGei6IcPXQ9P+qfukrhP9wkOpena+uTiBnswDsOevtwoMzXVTKnN q+wINCsZtNL0Mp9ui8K6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduvdehkeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdv uefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeejpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehrjhgrrhhrhiesrhgvughhrghtrdgtoh hmpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughsohhnsehinhhtvghlrdgtohhm pdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplhhumhgsvghrrdhorhhgpd hrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtohepshhhphgvrhgvthii sehnvhhiughirgdrtghomhdprhgtphhtthhopehvihgrtghhvghslhgrvhhosehnvhhiug hirgdrtghomhdprhgtphhtthhopehmsgesshhmrghrthhshhgrrhgvshihshhtvghmshdr tghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Oct 2025 04:42:59 -0400 (EDT) From: Thomas Monjalon To: Robin Jarry , Bruce Richardson Cc: Stephen Hemminger , dev@dpdk.org, shperetz@nvidia.com, viacheslavo@nvidia.com, mb@smartsharesystems.com Subject: Re: [PATCH v6 7/7] usertools/mbuf: parse mbuf history dump Date: Thu, 16 Oct 2025 10:42:57 +0200 Message-ID: <2863952.HovnAMPojK@thomas> In-Reply-To: References: <20250616072910.113042-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/10/2025 10:10, Bruce Richardson: > On Wed, Oct 15, 2025 at 09:41:18PM +0200, Robin Jarry wrote: > > Thomas Monjalon, Oct 15, 2025 at 21:11: > > > 15/10/2025 19:50, Stephen Hemminger: > > >> Minor stuff. > > >> > > >> $ flake8 --max-line-length=100 dpdk-mbuf-history-parser.py > > >> dpdk-mbuf-history-parser.py:14:1: F401 'sys' imported but unused > > >> dpdk-mbuf-history-parser.py:29:27: E203 whitespace before ':' > > > > > > Interesting, thanks. > > > > > > I'm a bit lost about Python linters. > > > I ran black, should I run flake8 + black? something else? > > > > Just black. Flake8 style is completely obsolete. The unused import > > warning is legit though. > > > > We should have a centralized python linter process in DPDK. The main > > issue is that most of the code will not pass as it is :D > > > ... yet! > > For python scripts in DPDK I wouldn't have a major issue about having a > patchset with the results of a black run on them. History tracking of the > python files is not as important as for the C files, since they don't have > that many bug fixes on them to root cause. Once we get everything nicely > formatted then we can mandate proper formatting going forward (and > integrate into CI perhaps). I fully agree.