[dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting

[dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting

[Daniel Shelepov]

When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects
burst statistics and includes them in the port stats report.  The
summary should include top 2 most frequent burst sizes, but there is a
bug in finding the top-2.  During the scan of burst size counts, the
top-2 can change only if top-1 also changes.

Added logic to update the top-2 if current burst size is larger than
existing top-2, but smaller than existing top-1.

Signed-off-by: Daniel Shelepov <dashel@microsoft.com>
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index db23f23e5..cc38e51fc 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -927,6 +927,9 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs)
 			pktnb_stats[1] = pktnb_stats[0];
 			burst_stats[0] = nb_burst;
 			pktnb_stats[0] = nb_pkt;
+		} else if (nb_burst > burst_stats[1]) {
+			burst_stats[1] = nb_burst;
+			pktnb_stats[1] = nb_pkt;
 		}
 	}
 	if (total_burst == 0)
-- 
2.15.1.gvfs.2.39.g03d366a

Re: [dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting

[Iremonger, Bernard]

Hi Daniel,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Shelepov
> Sent: Friday, May 4, 2018 9:12 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Daniel Shelepov <dashel@microsoft.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting
> 
> When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects
> burst statistics and includes them in the port stats report.  The summary
> should include top 2 most frequent burst sizes, but there is a bug in finding
> the top-2.  During the scan of burst size counts, the
> top-2 can change only if top-1 also changes.
> 
> Added logic to update the top-2 if current burst size is larger than existing
> top-2, but smaller than existing top-1.

Could you add a fixes line.

> 
> Signed-off-by: Daniel Shelepov <dashel@microsoft.com>
> ---
>  app/test-pmd/testpmd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> db23f23e5..cc38e51fc 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -927,6 +927,9 @@ pkt_burst_stats_display(const char *rx_tx, struct
> pkt_burst_stats *pbs)
>  			pktnb_stats[1] = pktnb_stats[0];
>  			burst_stats[0] = nb_burst;
>  			pktnb_stats[0] = nb_pkt;
> +		} else if (nb_burst > burst_stats[1]) {
> +			burst_stats[1] = nb_burst;
> +			pktnb_stats[1] = nb_pkt;
>  		}
>  	}
>  	if (total_burst == 0)
> --
> 2.15.1.gvfs.2.39.g03d366a

Regards,

Bernard

[dpdk-dev] [PATCH v2] app/testpmd: fix burst stat reporting

[Daniel Shelepov]

When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects
burst statistics and includes them in the port stats report.  The
summary should include top 2 most frequent burst sizes, but there is a
bug in finding the top-2.  During the scan of burst size counts, the
top-2 can change only if top-1 also changes.

Added logic to update the top-2 if current burst size is larger than
existing top-2, but smaller than existing top-1.

Fixes: af75078fece3 ("first public release")

Signed-off-by: Daniel Shelepov <dashel@microsoft.com>
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index db23f23e5..cc38e51fc 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -927,6 +927,9 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs)
 			pktnb_stats[1] = pktnb_stats[0];
 			burst_stats[0] = nb_burst;
 			pktnb_stats[0] = nb_pkt;
+		} else if (nb_burst > burst_stats[1]) {
+			burst_stats[1] = nb_burst;
+			pktnb_stats[1] = nb_pkt;
 		}
 	}
 	if (total_burst == 0)
-- 
2.15.1.gvfs.2.39.g03d366a

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix burst stat reporting

[Iremonger, Bernard]

> -----Original Message-----
> From: Daniel Shelepov [mailto:dashel@microsoft.com]
> Sent: Monday, May 14, 2018 10:12 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Daniel Shelepov <dashel@microsoft.com>
> Subject: [PATCH v2] app/testpmd: fix burst stat reporting
> 
> When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects
> burst statistics and includes them in the port stats report.  The summary
> should include top 2 most frequent burst sizes, but there is a bug in finding
> the top-2.  During the scan of burst size counts, the
> top-2 can change only if top-1 also changes.
> 
> Added logic to update the top-2 if current burst size is larger than existing
> top-2, but smaller than existing top-1.
> 
> Fixes: af75078fece3 ("first public release")
> 
> Signed-off-by: Daniel Shelepov <dashel@microsoft.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix burst stat reporting

[Thomas Monjalon]

> > When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects
> > burst statistics and includes them in the port stats report.  The summary
> > should include top 2 most frequent burst sizes, but there is a bug in finding
> > the top-2.  During the scan of burst size counts, the
> > top-2 can change only if top-1 also changes.
> > 
> > Added logic to update the top-2 if current burst size is larger than existing
> > top-2, but smaller than existing top-1.
> > 
> > Fixes: af75078fece3 ("first public release")
> > 
> > Signed-off-by: Daniel Shelepov <dashel@microsoft.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Applied, thanks