From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91097A0093; Tue, 19 May 2020 16:24:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BF001D607; Tue, 19 May 2020 16:24:56 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 18EDB1D5E1; Tue, 19 May 2020 16:24:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 9B68C5818CF; Tue, 19 May 2020 10:24:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 19 May 2020 10:24:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= YXroSdvTDtMZPbyWXzsEJvjQuJ8pOdIcUX8JeUyHipA=; b=cRKyHkOO0P0SAHBk VDed6IW1+Wwzc+BUEBVky+Dqd93pKM+tKtnTnR+5mjocC2oLLZxOoA8t1ACNzbDJ NzLaCcZ7+NHXZpMjOj+FkjSrG7Ua5uGOhVupk3xUDVi5gibRCKn+fAboy+btEqCf syrQjk5qQmqSN491g8I0iJh05WLxag4CBBXpK8bjSTM+DBfy5RIJEiPyQwFODpoX Som60VAdDsn4QCB8eBfmlf+eWKJnAoIiDP7Bk/cm7UHKyo7jEBPIYCa4RjgUDNFq tXOHO3qO4Lml4ItpREe6+EuZ72OxwT+WzwRmpO3AViB0oX54JOLqm/S+LfkOEHAx pKqaHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=YXroSdvTDtMZPbyWXzsEJvjQuJ8pOdIcUX8JeUyHi pA=; b=4dkI7y0+f89Dzu1L2fPz4EoE6VTAKuDhGBHN/hQsTKghRQl//P8tsznc7 IPuNxeXeLBGo1n3vkBi7awSTS6DlJuIYvIeTkJ0wu6Q7c8kED0s2JrZSVelvAXJZ xukhTRpAbjM26h+2TBCJ0U2q0vkyXKnTnBhu0FHkw1pNi0cLMWJ2KIZ7IEp/9A8y xEjkOypPAzr73HUJYo5oFIeDoBRx27K+/TRSDU6tG6OpYVTUNMc1UWRra0h0aw+O yT4rQb9rSdFvegt/GfXmjUK7iJ9kNJ9x+IfL3WwNUFhtrOjV/BIqGRFlmL/ENnI1 A7fTrgrujoqm7fIXOh7DRxHtzrnBg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtjedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 60F9E3066434; Tue, 19 May 2020 10:24:49 -0400 (EDT) From: Thomas Monjalon To: "Yigit, Ferruh" , "Dumitrescu, Cristian" Cc: Ray Kinsella , Neil Horman , Eelco Chaudron , dev@dpdk.org, David Marchand , "stable@dpdk.org" , Luca Boccassi , "Richardson, Bruce" , "Stokes, Ian" , Andrzej Ostruszka , "techboard@dpdl.org" Date: Tue, 19 May 2020 16:24:47 +0200 Message-ID: <2865818.9VTjjQsp5K@thomas> In-Reply-To: References: <20200513121149.2283385-1-ferruh.yigit@intel.com> <20200519121629.3590459-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] meter: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/05/2020 15:26, Dumitrescu, Cristian: > From: Yigit, Ferruh > > > > On v20.02 some meter APIs have been matured and symbols moved from > > EXPERIMENTAL to DPDK_20.0.1 block. > > > > This can break the applications that were using these mentioned APIs on > > v19.11. Although there is no modification on the APIs and the action is > > positive and matures the APIs, the affect can be negative to > > applications. > > > > This patch provides aliasing by duplicating the existing and versioned > > symbols as experimental. > > > > Since symbols moved from DPDK_20.0.1 to DPDK_21 block in the v20.05, the > > aliasing done between EXPERIMENTAL and DPDK_21. > > > > With DPDK_21 ABI (DPDK v20.11) all aliasing will be removed and only > > stable version of the APIs will remain. > > > > Fixes: 30512af820fe ("meter: remove experimental flag from RFC4115 trTCM > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > Acked-by: Cristian Dumitrescu > > Thanks, Ferruh and Ray! > > I am OK to let this is temporarily until release 20.11. Applied, thanks > Regarding the API breakage larger problem, > this method only fixes the case of experimental APIs transitioning > to non-experimental status with no modifications, Yes > but it does not handle the following possible cases: > > 1. Experimental APIs transitioning to non-experimental status with some modifications. If there is a modification, it should mature as experimental first. > 2. Experimental APIs being removed. No guarantee that an experimental API remains forever. > 3. Non-experimental APIs transitioning to deprecated status. I don't think we need to deprecate experimental API. We can change or remove them freely at any time. > We need a clear procedure & timing for all these cases > to avoid similar situations in the future. > Likely a good topic for techboard discussion. We can ask if there are different opinions. I think the experimental status is quite clear: no guarantee.