From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 649E81DB1 for ; Thu, 13 Apr 2017 12:21:07 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 03:21:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="88632543" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 13 Apr 2017 03:21:05 -0700 To: Wei Zhao , dev@dpdk.org References: <1492069767-26440-1-git-send-email-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: <2866c3e3-bc04-f919-f533-23dc38bafbc7@intel.com> Date: Thu, 13 Apr 2017 11:21:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <1492069767-26440-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: remove tpid check for fdir filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 10:21:07 -0000 On 4/13/2017 8:49 AM, Wei Zhao wrote: > DPDK community has several emails discussion on this topic, > these mails name is "FW: Issues with ixgbe and rte_flow", Can you please add reference to discussions by mail list archive links. Like: http://dpdk.org/ml/archives/dev/2017-April/063942.html > items like VLAN can already have several valid "types" > (0x88a8, 0x8100, 0x9100), and who knows what will come up > in the future.And ixgbe_flow just ignores the types when do > filter configuration. So it may be reasonable to delete the > related tpid check process. > Also add some more comment log on stack explanation. > > Fixes: 11777435c72 ("net/ixgbe: parse flow director filter") > > Signed-off-by: Wei Zhao <...>