From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2D32F1B5EA; Sun, 5 Aug 2018 14:53:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9E6662134B; Sun, 5 Aug 2018 08:53:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 Aug 2018 08:53:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=xrUdcx4hoPpuI48HCkykio78gi WH9T3angxDm9FDt2k=; b=WPdBczKaq6TMhhAqIyqfHRgNf34zgjvMx3mXFV+Vbn kpk45uU/cipicre47xdm6u+yVpjMUhKj6KHCehKrIf5r2In/dGeU2PxVdFmSc2Nt rVdAtyWS2jFfahW/dXokG7uuBrBaGCzPd3oZCWaZ4sue+Gc191LbZRtvfd/SU75Z 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=xrUdcx 4hoPpuI48HCkykio78giWH9T3angxDm9FDt2k=; b=UKASyqYoyC3ADAoqxPGoSG amECaw8eTd7Xgh2pV18wyCnzr9DsB/UdKUnND1RjaZdBoreH8nUqePhNFntpTKXO gN6pebo2Vuvcykb/jnpAF+gaOYsL6ADr1mLurn3pygHS1BxuLmVEAJFZubiXsy6z GEVCFlgMmzHMqBvHjn8kM+Tewskw89/BLogut612318lE/fqAy7/LvmhPmLgNEs7 42cRHn2dA+7HlvWjDAUypP0HZQhMgfFv6FNCaAGX4ociZaVbjneFqVYaY8S4Pqxb lQaQLyq8Ev3IiLSqNtrbxuqtnqDIdKnRUvO/mAOJO9R4dmycSodBrGkXMQG6useg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (221.87.136.77.rev.sfr.net [77.136.87.221]) by mail.messagingengine.com (Postfix) with ESMTPA id C9273E4074; Sun, 5 Aug 2018 08:53:01 -0400 (EDT) From: Thomas Monjalon To: Harry van Haaren Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org, jerin.jacob@caviumnetworks.com Date: Sun, 05 Aug 2018 14:52:56 +0200 Message-ID: <2872510.F3tLCBEot3@xps> In-Reply-To: <1533221009-99302-1-git-send-email-harry.van.haaren@intel.com> References: <1533198964-30218-1-git-send-email-harry.van.haaren@intel.com> <1533221009-99302-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] event: fix check in ring init() in event ring code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2018 12:53:06 -0000 02/08/2018 16:43, Harry van Haaren: > This commit fixes a bug in a 32-bit environment where the > generic ring_init() would fail, but given the interaction > with memzones the next iteration of the event_ring_autotest > would actually *pass* because the ring in question would > exist already an be looked-up. > > This commit rightly error checks the result of ring_init(), > and calls rte_free() on the memory as required. > > Fixes: dc39e2f359b5 ("eventdev: add ring structure for events") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Harry van Haaren > Acked-by: Jerin Jacob > > --- > > v2: > - Removed _ from headline for check git log (Jerin) This is not the spirit of this check. You are expected to not use function names at all, in order to provide a title readable by someone who does not know the function or structure names of this area. In this case, it can be: event: fix ring init failure handling > - Added memzone free (good catch, thanks Jerin) > - Return NULL instead of 0 (Jerin) > - Added Jerin's Ack > > Cc: thomas@monjalon.net > Cc: jerin.jacob@caviumnetworks.com > > Please consider this for RC3, as it fixes the unit tests > on 32-bit systems. Applied, thanks