From: Thomas Monjalon <thomas@monjalon.net>
To: "Minggang Li(Gavin)" <gavinl@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, viacheslavo@nvidia.com, matan@nvidia.com,
orika@nvidia.com, Dariusz Sosnowski <dsosnowski@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
rasland@nvidia.com, Rongwei Liu <rongweil@nvidia.com>
Subject: Re: [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization
Date: Thu, 31 Oct 2024 20:30:43 +0100 [thread overview]
Message-ID: <2873618.Nya5fj1elA@thomas> (raw)
In-Reply-To: <20241029092039.7dcc5525@hermes.local>
29/10/2024 17:20, Stephen Hemminger:
> On Tue, 29 Oct 2024 15:42:52 +0200
> "Minggang Li(Gavin)" <gavinl@nvidia.com> wrote:
>
> > From: Rongwei Liu <rongweil@nvidia.com>
> >
> > Add a new devarg probe_opt_en to control probe optimization
> > in PMD.
> >
> > By default, the value is 0 and no behavior changed.
> >
> > Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>
> Once again, every option you introduce expands the test space by 2X.
> "Do or Do not. There is no try"
> Either it works all the time or it is a bad idea.
I fully agree.
We should not merge this series before providing a good answer,
or making it automatic.
One more thing: a commit log should always explain "why".
Here it should say why it is not automatic.
Is there a good reason to disable this feature?
> Sorry if I sound like a broken record, the project I used to work on
> had the same kind of "always add an option" policy. But every time
> an option was changed, there was a 50/50 chance that it was broken because
> that combination of options had not been tested since originally added
> and was non functional due to bit rot.
next prev parent reply other threads:[~2024-10-31 19:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 8:38 [PATCH V1 0/7] port probe time optimization Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 1/7] mailmap: update user name Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 2/7] net/mlx5: optimize device probing Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 3/7] net/mlx5: add new devargs to control probe optimization Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 4/7] common/mlx5: fix Netlink socket leak Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 5/7] common/mlx5: add RDMA monitor event awareness Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 6/7] mlx5: use RDMA Netlink to update port information Minggang Li(Gavin)
2024-10-16 8:38 ` [PATCH V1 7/7] mlx5: add backward compatibility for RDMA monitor Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 0/7] port probe time optimization Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 1/7] mailmap: update user name Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 2/7] net/mlx5: optimize device probing Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 3/7] net/mlx5: add new devargs to control probe optimization Minggang Li(Gavin)
2024-10-28 15:47 ` Stephen Hemminger
2024-10-29 8:27 ` Minggang(Gavin) Li
2024-10-29 16:07 ` Stephen Hemminger
2024-10-30 8:16 ` Slava Ovsiienko
2024-10-30 19:05 ` Stephen Hemminger
2024-10-28 9:18 ` [PATCH V2 4/7] common/mlx5: fix Netlink socket leak Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 5/7] common/mlx5: add RDMA monitor event awareness Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 6/7] mlx5: use RDMA Netlink to update port information Minggang Li(Gavin)
2024-10-28 9:18 ` [PATCH V2 7/7] mlx5: add backward compatibility for RDMA monitor Minggang Li(Gavin)
2024-10-28 15:49 ` Stephen Hemminger
2024-10-29 8:31 ` Minggang(Gavin) Li
2024-10-29 13:42 ` [PATCH V3 0/7] port probe time optimization Minggang Li(Gavin)
2024-10-29 13:42 ` [PATCH V3 1/7] mailmap: update user name Minggang Li(Gavin)
2024-10-29 13:42 ` [PATCH V3 2/7] net/mlx5: optimize device probing Minggang Li(Gavin)
2024-10-29 13:42 ` [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization Minggang Li(Gavin)
2024-10-29 16:20 ` Stephen Hemminger
2024-10-31 19:30 ` Thomas Monjalon [this message]
2024-10-29 13:42 ` [PATCH V3 4/7] common/mlx5: fix Netlink socket leak Minggang Li(Gavin)
2024-10-29 13:42 ` [PATCH V3 5/7] common/mlx5: add RDMA monitor event awareness Minggang Li(Gavin)
2024-10-29 13:42 ` [PATCH V3 6/7] mlx5: use RDMA Netlink to update port information Minggang Li(Gavin)
2024-10-29 13:42 ` [PATCH V3 7/7] mlx5: add backward compatibility for RDMA monitor Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 0/7] port probe time optimization Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 1/7] mailmap: update user name Minggang Li(Gavin)
2024-10-31 10:01 ` Raslan Darawsheh
2024-10-29 14:31 ` [PATCH V3 2/7] net/mlx5: optimize device probing Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 4/7] common/mlx5: fix Netlink socket leak Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 5/7] common/mlx5: add RDMA monitor event awareness Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 6/7] mlx5: use RDMA Netlink to update port information Minggang Li(Gavin)
2024-10-29 14:31 ` [PATCH V3 7/7] mlx5: add backward compatibility for RDMA monitor Minggang Li(Gavin)
2024-10-29 16:26 ` Stephen Hemminger
2024-10-30 8:25 ` Minggang(Gavin) Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2873618.Nya5fj1elA@thomas \
--to=thomas@monjalon.net \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=gavinl@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).