From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F17245C28; Thu, 31 Oct 2024 20:30:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BB494028A; Thu, 31 Oct 2024 20:30:51 +0100 (CET) Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) by mails.dpdk.org (Postfix) with ESMTP id 2675A40264 for ; Thu, 31 Oct 2024 20:30:50 +0100 (CET) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.stl.internal (Postfix) with ESMTP id 33AB82540197; Thu, 31 Oct 2024 15:30:49 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Thu, 31 Oct 2024 15:30:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1730403049; x=1730489449; bh=9XXpK6itEPCxze7uw/Bi9IEHCDrpr826LHOcB6xPMOg=; b= qGANMwjy7pp+B7i5a71CKb0ZPz/TmX0MAClZCFxG1f9SuerRm5CFoN+NLe11ZgCz gGgNRU2AHwccACQ2MzW60jLDskdmxThshwYFq9IG25MBxapJWtPQQQjuUvV047mN YhuUMUZb+tOFaoo14zGfBYYcajajhUdgEffLbmmSpEGdgGOl5/VzRNhk6+KXLdxv X7UryX9Y+wquyOZrFQRafQevEANS6MGq+rusbMjLGcgWfUqDCVYwoRt6DRpyG7vF /2vYAEO8g7lezvRZ1e99vaoOQyk5cS0UOP5Tvd5qhVJ1ZCHLpdQRyyQJwfbIsHTW 0j9Rc9sfM57npIK6xszD7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730403049; x= 1730489449; bh=9XXpK6itEPCxze7uw/Bi9IEHCDrpr826LHOcB6xPMOg=; b=P aHOuhSBt+JlKnWOQpgFCh9XrDs/htH/R2KLdD6njvzgf4qV/XvizSeDI6hSh1/hf iw17VVREMi6cj/xmY1eStZUUgnVG8TyjuNTocoUDKa6WezNMvYZs6aZHG1WOPRUB rpqdEgjLN7c3D5p+euLhexWi9Pp5we2NxwGMTJeRl7nGptSLwODpkYa0dLEWn2kT iF73WCSq7hjp0pWKmXVvhUBjt8B7jTJHtygNp3XM3MNsNbtQ1gcn5a+YefZ+sfTu hHCaJsedWHVJlnUHq09DN7HMS1R057kiaYyjwczeCsXVUYC+JXrITXBng2pnaamQ sqf0Ov7R2dC2yZ73H7Dwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekjedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeduuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghgrvh hinhhlsehnvhhiughirgdrtghomhdprhgtphhtthhopehsthgvphhhvghnsehnvghtfiho rhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprh gtphhtthhopehvihgrtghhvghslhgrvhhosehnvhhiughirgdrtghomhdprhgtphhtthho pehmrghtrghnsehnvhhiughirgdrtghomhdprhgtphhtthhopehorhhikhgrsehnvhhiug hirgdrtghomhdprhgtphhtthhopegushhoshhnohifshhkihesnhhvihguihgrrdgtohhm pdhrtghpthhtohepsghinhhgiiesnhhvihguihgrrdgtohhmpdhrtghpthhtohepshhurg hnmhhinhhgmhesnhhvihguihgrrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Oct 2024 15:30:45 -0400 (EDT) From: Thomas Monjalon To: "Minggang Li(Gavin)" , Stephen Hemminger Cc: dev@dpdk.org, viacheslavo@nvidia.com, matan@nvidia.com, orika@nvidia.com, Dariusz Sosnowski , Bing Zhao , Suanming Mou , rasland@nvidia.com, Rongwei Liu Subject: Re: [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization Date: Thu, 31 Oct 2024 20:30:43 +0100 Message-ID: <2873618.Nya5fj1elA@thomas> In-Reply-To: <20241029092039.7dcc5525@hermes.local> References: <20241028091822.860660-8-gavinl@nvidia.com> <20241029134256.874767-4-gavinl@nvidia.com> <20241029092039.7dcc5525@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/10/2024 17:20, Stephen Hemminger: > On Tue, 29 Oct 2024 15:42:52 +0200 > "Minggang Li(Gavin)" wrote: > > > From: Rongwei Liu > > > > Add a new devarg probe_opt_en to control probe optimization > > in PMD. > > > > By default, the value is 0 and no behavior changed. > > > > Signed-off-by: Rongwei Liu > > Acked-by: Viacheslav Ovsiienko > > Once again, every option you introduce expands the test space by 2X. > "Do or Do not. There is no try" > Either it works all the time or it is a bad idea. I fully agree. We should not merge this series before providing a good answer, or making it automatic. One more thing: a commit log should always explain "why". Here it should say why it is not automatic. Is there a good reason to disable this feature? > Sorry if I sound like a broken record, the project I used to work on > had the same kind of "always add an option" policy. But every time > an option was changed, there was a 50/50 chance that it was broken because > that combination of options had not been tested since originally added > and was non functional due to bit rot.