From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A46DDA04E0; Thu, 28 Nov 2019 11:50:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27C4628EE; Thu, 28 Nov 2019 11:50:37 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id D6512A3 for ; Thu, 28 Nov 2019 11:50:35 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2B4EEBA8; Thu, 28 Nov 2019 05:50:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 28 Nov 2019 05:50:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=K2KBbMEgWO+jCaHPtkfx1yYdq34lhj2nxtJLwGPYkT0=; b=g/Tlkzy7skY0 Eu3SN4ohdyrCXJyIGipIJAXundTpzM2A7jiTW8x6qKB/iRF5/cwln6kKUpTiU1Mi yivarlgwD38O8QWFLGaZKz16Dq3uYx6Plb7pl0nMUH6jfxCeyJaNaTnDfZkszEcL 1xzWY+BlTwmBtZ2Ih/SNkycP6ndOAfA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=K2KBbMEgWO+jCaHPtkfx1yYdq34lhj2nxtJLwGPYk T0=; b=N+u9f6Y4i8PLLKmOedRHzKwGkaOYNZcfc6/aTVMMzC6604NP84za82p5d gPQVF66kWJi7PpjqmmY3jZdnIWpjdaVb5m3Z11g8lbwrLJDD3OTAp52GLeK6U/3h xoHFgggKepltZv25Jhb7KPtLwMQ9CtX+m4IiEGnfpl7wwsj5mnwVdODM74Znhv7Z XMfOoqW3rO1xGyT6f1WNY0SLj41LC0nJzXpKJvLyWzcPiUFiMRJqEnXO4zOWfrw3 FTOESD30ke21NY7JpcESUrpUOveBZ+vydnSyl67HDrTtgp7WHODY+Hm+hk/JNHS0 RJv+KvJ/Pog0L9NYhkroblPpQANKA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeijedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7EE9180060; Thu, 28 Nov 2019 05:50:31 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko Cc: David Marchand , Vamsi Attunuru , Jerin Jacob , Ferruh Yigit , John McNamara , Marko Kovacevic , dev , Kiran Kumar K , Igor Ryzhov Date: Thu, 28 Nov 2019 11:50:29 +0100 Message-ID: <2874765.WT4eTNfbIK@xps> In-Reply-To: References: <20191120160009.46270-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/11/2019 11:44, Andrew Rybchenko: > On 11/21/19 1:30 AM, David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:28 PM David Marchand > > wrote: > >> On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit = wrote: > >>> A build error reported related to the selected > >>> 'get_user_pages_remote()' kernel API: > >>> > >>> .../kernel/linux/kni/kni_dev.h:113:8: > >>> error: too few arguments to function =E2=80=98get_user_pages_remote= =E2=80=99 > >>> ret =3D get_user_pages_remote(tsk, tsk->mm, iova, 1 > >>> ^~~~~~~~~~~~~~~~~~~~~ > >>> > >>> Currently there are three version of the 'get_user_pages_remote()' > >>> supported, based on kernel version > >>> < 4.9, =3D 4.9, > 4.9 > >>> > >>> These version based checks are not working fine with the distro kerne= ls > >>> which is the cause of reported build error. The error reported by the > >>> kernel version 4.8, but it is using API defined in > 4.9. > >>> > >>> To be able to take control of this, and possible more, related build > >>> error, increasing the minimum supported kernel version for iova=3Dva = with > >>> KNI to kernel version 4.9. > >>> > >>> This leaves us with single version of the kernel API and more > >>> manageable. > >>> > >>> Signed-off-by: Ferruh Yigit > > Reviewed-by: David Marchand > > > > We need this change to fix compilation issues for -rc3. > > Applied, thanks. >=20 > The build is still broken on Debian 9 stretch which has Linux 4.9.189, > but corresponding function still has no the last argument. > It looks like requirements should be bumped to >=3D4.10.0. No opinion. I am fine with any fix (today).