From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AC74A0577; Mon, 6 Apr 2020 13:16:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00B0B1BF0B; Mon, 6 Apr 2020 13:16:36 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id B10721BF0B for ; Mon, 6 Apr 2020 13:16:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id ED93D580164; Mon, 6 Apr 2020 07:16:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Apr 2020 07:16:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=V6TCRqF2rdVJAR/NTVWLmoMDD2JRjz9dSHCocnVKAnU=; b=NC5XEVC8QIFL h1p+XRSFa89IpmeARR4x14lNR7+PHti+CXZnne7OrpFwTh4AmtsDPfdkoLdN6VGz 8kVX+rhaA0yBrVdP5jehzPJesswr4ae2Rj04WQp+/VX0EvxXCJvVhJ5sOZ9Wuyuk w/rAcgxvQSJcQj0QlkuMqJg67C8+FVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=V6TCRqF2rdVJAR/NTVWLmoMDD2JRjz9dSHCocnVKA nU=; b=E2E56mXnVj8GJgsFl9pFbjP14M0Mbbh6UM4Nb5AP5eP0DrshMVRNQWyU5 a/H1kSCjheUx9V7SKZ2zkrfKrMP6vCbWGlS2r6dcL6Z0b5U1xOdnPXe5kZmk53CC hFvUaKT8CuU0uoTKUXI3Ye/bTcJxWmVxliOvYtmuM+f4tmwSwNkTCPZygCb60Az1 Uqq8lTLXc/b7tz9wFbfY4BPEOPLqfCjkV34JJEqqXvlIHk66k77SK/hCkxWCCec6 VeRovIMyY1oba6qnJJ29kInXpKa2QPxOy3HN5tAtLklS/x1pHov9V4MokYHYu36u dedTQqAwKt+aDJqkRTVXkgKaOS5SA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 030DD306D3EA; Mon, 6 Apr 2020 07:16:24 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula , Ori Kam Cc: Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , david.marchand@redhat.com Date: Mon, 06 Apr 2020 13:16:24 +0200 Message-ID: <2875521.ySyUEvhnHf@xps> In-Reply-To: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/04/2020 17:04, Ori Kam: > From: Pavan Nikhilesh Bhagavatula > > >+uint16_t > > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > > >+ struct rte_regex_ops **ops, uint16_t nb_ops) > > >+{ > > >+ return regex_devices[dev_id]- > > >>enqueue(regex_devices[dev_id], qp_id, > > >+ ops, nb_ops); > > >+} > > > > Move these functions to .h in-lining them. > > Also, please add debug checks @see rte_eth_rx_burst/rte_eth_tx_burst. > > O.K will update. In general, inlining is a pain for ABI compatibility. Please inline only if the gain is very significant.