From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "lihuisong (C)" <lihuisong@huawei.com>,
fengchengwen <fengchengwen@huawei.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Dengdui Huang <huangdengdui@huawei.com>
Cc: dev@dpdk.org, Song Jiale <songx.jiale@intel.com>,
Zhimin Huang <zhiminx.huang@intel.com>,
"Xu, HailinX" <hailinx.xu@intel.com>
Subject: Re: [PATCH] app/testpmd: fix set Tx offload command
Date: Fri, 17 Nov 2023 10:19:55 +0000 [thread overview]
Message-ID: <28756c44-9a6c-4871-ac95-1d8d7041a35a@amd.com> (raw)
In-Reply-To: <9016ca9e-8f26-d086-dec5-c02cf358fd93@huawei.com>
On 11/17/2023 1:31 AM, lihuisong (C) wrote:
>> On 2023/11/17 1:21, Ferruh Yigit wrote:
>>> In command to set Tx offload:
>>> "port config <port_id> tx_offload <offload> on|off",
>>>
>>> there is a defect in "on|off" comparison, so command does opposite of
>>> what is intended. Fixed comparison.
>>>
>>> Fixes: 6280fe565b44 ("app/testpmd: allow offload config for all ports")
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>
>> Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
>>
>
> Acked-by: Huisong Li <lihuisong@huawei.com>
>
Bugzilla ID: 1326
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-11-17 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 17:21 Ferruh Yigit
2023-11-17 1:05 ` fengchengwen
2023-11-17 1:31 ` lihuisong (C)
2023-11-17 10:19 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28756c44-9a6c-4871-ac95-1d8d7041a35a@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=hailinx.xu@intel.com \
--cc=huangdengdui@huawei.com \
--cc=lihuisong@huawei.com \
--cc=songx.jiale@intel.com \
--cc=yuying.zhang@intel.com \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).